After saving a file, Javadoc not shown on hover

[fbricon]

When hovering over a class or method or module you just opened, the Javadoc shows up as expected. If the javadoc is modified, javadoc on hover is updated.
As soon as the file is saved, javadoc is not shown anymore.

Turns out, this returns null:

ISourceRange javadocRange= member.getJavadocRange();

In Member.java, we have

public ISourceRange getJavadocRange() throws JavaModelException {
	ISourceRange range= getSourceRange();
	if (range == null) return null;
	IBuffer buf= null;
	if (isBinary()) {
		buf = getClassFile().getBuffer();
	} else {
		ICompilationUnit compilationUnit = getCompilationUnit();
		if (!compilationUnit.isConsistent()) {
			return null;
		}

The problem is compilationUnit.isConsistent() returns false. If we dig deeper, we see that, in CompilationUnit:

public boolean isConsistent() {
	return !JavaModelManager.getJavaModelManager().getElementsOutOfSynchWithBuffers().contains(this);
}

So, for some reason, the compilation unit, after saving the file, ends up in JavaModelManager.elementsOutOfSynchWithBuffers

[fbricon]

So this is tricky: the buffer is put out of sync because a document change event is fired AFTER the workspace operation finishes to save the file :

JavaModelManager.getElementsOutOfSynchWithBuffers() line: 2132	
CompilationUnit(Openable).bufferChanged(BufferChangedEvent) line: 53	
DocumentAdapter.fireBufferChanged(BufferChangedEvent) line: 298	
DocumentAdapter.documentChanged(DocumentEvent) line: 289	
SynchronizableDocument(AbstractDocument).doFireDocumentChanged2(DocumentEvent) line: 744	
SynchronizableDocument(AbstractDocument).doFireDocumentChanged(DocumentEvent, boolean, IRegion) line: 713	
SynchronizableDocument(AbstractDocument).doFireDocumentChanged(DocumentEvent) line: 697	
SynchronizableDocument(AbstractDocument).fireDocumentChanged(DocumentEvent) line: 771	
SynchronizableDocument(AbstractDocument).set(String, long) line: 1142	
SynchronizableDocument.set(String, long) line: 197	
ResourceTextFileBuffer.handleFileContentChanged(boolean, boolean) line: 466	
ResourceFileBuffer$FileSynchronizer$2.execute() line: 148	
ResourceFileBuffer$FileSynchronizer$2(ResourceFileBuffer$SafeFileChange).run() line: 83	
ResourceFileBuffer$FileSynchronizer.resourceChanged(IResourceChangeEvent) line: 183	
NotificationManager$1.run() line: 299	
SafeRunner.run(ISafeRunnable) line: 42	
NotificationManager.notify(ResourceChangeListenerList$ListenerEntry[], ResourceChangeEvent, boolean) line: 289	
NotificationManager.broadcastChanges(ElementTree, ResourceChangeEvent, boolean) line: 152	
Workspace.broadcastPostChange() line: 374	
Workspace.endOperation(ISchedulingRule, boolean) line: 1469	
Workspace.run(ICoreRunnable, ISchedulingRule, int, IProgressMonitor) line: 2253	
Workspace.run(IWorkspaceRunnable, IProgressMonitor) line: 2262	
DocumentLifeCycleHandler.didSave(DidSaveTextDocumentParams) line: 186	

Not sure how to handle that. @gorkem, @aeschli, @snjeza, @tsmaeder ideas?

[aeschli]

I guess the question is, how does the resource change event get triggered. It seems to happen while saving, or even be a side effect of saving.
I'd suggest to nail it down in the DocumentLifeCycleHandlerTest, e.g here