Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP #1796 - Header part shows no data and crashes #1797

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

eselmeister
Copy link
Contributor

An option has been added to use the rich or plain text editor. Additionally, a check could be added to test if WebKit is available on the system.

An option has been added to use the rich or plain text editor.
Additionally, a check could be added to test if WebKit is available on
the system.
@Mailaender
Copy link
Contributor

Instead of yet another checkbox, it might be better to just display the error message of the SWTError in the control or in the feedback tab. Otherwise, you have to default to plain text editor to avoid the crash.

@eselmeister
Copy link
Contributor Author

By default, a plain text editor displays the data now. If the user likes to activate the RTF editor, then on demand. It's a way to ensure, that the header data is displayed on platforms where WebKit is not available.

@eselmeister eselmeister merged commit 4ff1a26 into develop Jul 3, 2024
3 checks passed
@eselmeister eselmeister deleted the 1796_RichTextEditorCrash branch July 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants