Increased mzML standards compliance and openMS compatibility #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
validate-mzml
branch
from
b8070bf to
3c00666
Compare
eselmeister
requested changes
Jun 14, 2023
There was a problem hiding this comment.
Please address the following issues:
Description Resource Path Location Type
Bundle 'org.apache.commons.commons-codec' cannot be resolved MANIFEST.MF /org.eclipse.chemclipse.msd.converter.supplier.mzml/META-INF line 18 Plug-in Problem
DigestUtils cannot be resolved ChromatogramWriterVersion110.java /org.eclipse.chemclipse.msd.converter.supplier.mzml/src/org/eclipse/chemclipse/msd/converter/supplier/mzml/internal/io line 331 Java Problem
The import org.apache.commons.codec cannot be resolved ChromatogramWriterVersion110.java /org.eclipse.chemclipse.msd.converter.supplier.mzml/src/org/eclipse/chemclipse/msd/converter/supplier/mzml/internal/io line 25 Java Problem
Type mismatch: cannot convert from float to int ChromatogramReader.java /net.openchrom.msd.converter.supplier.mzmlb/src/net/openchrom/msd/converter/supplier/mzmlb/io line 104 Java Problem
The org.apache.commons.commons-codec bundle has been referenced. Has it been also added to the target platform?
The data type in the mzmlb bundle int multiplicator = XmlReader110.getTimeMultiplicator(cvParamScan); needs to be adjusted.
Mailaender
force-pushed
the
validate-mzml
branch
from
3c00666 to
6c497f8
Compare
|
|
eselmeister
approved these changes
Jun 14, 2023
Mailaender
force-pushed
the
validate-mzml
branch
3 times, most recently
from
08dd253 to
f86ca60
Compare
Mailaender
force-pushed
the
validate-mzml
branch
from
f86ca60 to
0e4ca0c
Compare
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OpenChrom/openchrom#370