-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java Testing support Bug fixes and Enhancements - Step 2 #4481
Conversation
Can one of the admins verify this patch? |
@davidfestal - thank you for the contribution! I'm thinking about how we get this packaged for marketing and release notes. We'll need a few things to get this marketing-ready (in addition to the code review of the code itself):
Thanks for this. |
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Some Java Editor action were added in the explorer context menu, which led to strange behaviors. Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Fixes [CHE-157](https://issues.jboss.org/browse/CHE-157) Signed-off-by: David Festal <[email protected]>
@davidfestal can you resolve conflicts, please? |
I just did it locally today. I'll push very soon. |
Signed-off-by: David Festal <[email protected]>
@vparfonov done ! |
thx @davidfestal, we made QA circle, got some regression so need to fix some Selenium tests. We will merge it next week |
@TylerJewell : let me answer your 3 points:
|
@vparfonov Thanks ! |
…#4481) * Show all tests in the result view, but allow filtering successful tests * Fix various navigation bugs from test view to source code * Remove the invalid command preview added by default * Fix https://issues.jboss.org/browse/CHE-149 Some Java Editor action were added in the explorer context menu, which led to strange behaviors. * Correctly propagate sevrer errors to the client status notifications * Change contextual test menu to `Run Test` Fixes [CHE-157](https://issues.jboss.org/browse/CHE-157) * Compilation error after the *Intelligent Commands* changes Signed-off-by: David Festal <[email protected]> Conflicts: plugins/plugin-testing-java/plugin-testing-junit/che-plugin-testing-junit-server/pom.xml plugins/plugin-testing/che-plugin-testing-ide/src/main/java/org/eclipse/che/plugin/testing/ide/view/TestResultViewImpl.java
…#4481) * Show all tests in the result view, but allow filtering successful tests * Fix various navigation bugs from test view to source code * Remove the invalid command preview added by default * Fix https://issues.jboss.org/browse/CHE-149 Some Java Editor action were added in the explorer context menu, which led to strange behaviors. * Correctly propagate sevrer errors to the client status notifications * Change contextual test menu to `Run Test` Fixes [CHE-157](https://issues.jboss.org/browse/CHE-157) * Compilation error after the *Intelligent Commands* changes Signed-off-by: David Festal <[email protected]> Conflicts: plugins/plugin-testing-java/plugin-testing-junit/che-plugin-testing-junit-server/pom.xml plugins/plugin-testing/che-plugin-testing-ide/src/main/java/org/eclipse/che/plugin/testing/ide/view/TestResultViewImpl.java
* Show all tests in the result view, but allow filtering successful tests * Fix various navigation bugs from test view to source code * Remove the invalid command preview added by default * Fix https://issues.jboss.org/browse/CHE-149 Some Java Editor action were added in the explorer context menu, which led to strange behaviors. * Correctly propagate sevrer errors to the client status notifications * Change contextual test menu to `Run Test` Fixes [CHE-157](https://issues.jboss.org/browse/CHE-157) * Compilation error after the *Intelligent Commands* changes Signed-off-by: David Festal <[email protected]> Conflicts: plugins/plugin-testing-java/plugin-testing-junit/che-plugin-testing-junit-server/pom.xml plugins/plugin-testing/che-plugin-testing-ide/src/main/java/org/eclipse/che/plugin/testing/ide/view/TestResultViewImpl.java
…#4481) * Show all tests in the result view, but allow filtering successful tests * Fix various navigation bugs from test view to source code * Remove the invalid command preview added by default * Fix https://issues.jboss.org/browse/CHE-149 Some Java Editor action were added in the explorer context menu, which led to strange behaviors. * Correctly propagate sevrer errors to the client status notifications * Change contextual test menu to `Run Test` Fixes [CHE-157](https://issues.jboss.org/browse/CHE-157) * Compilation error after the *Intelligent Commands* changes Signed-off-by: David Festal <[email protected]> Conflicts: plugins/plugin-testing-java/plugin-testing-junit/che-plugin-testing-junit-server/pom.xml plugins/plugin-testing/che-plugin-testing-ide/src/main/java/org/eclipse/che/plugin/testing/ide/view/TestResultViewImpl.java
…#4481) * Show all tests in the result view, but allow filtering successful tests * Fix various navigation bugs from test view to source code * Remove the invalid command preview added by default * Fix https://issues.jboss.org/browse/CHE-149 Some Java Editor action were added in the explorer context menu, which led to strange behaviors. * Correctly propagate sevrer errors to the client status notifications * Change contextual test menu to `Run Test` Fixes [CHE-157](https://issues.jboss.org/browse/CHE-157) * Compilation error after the *Intelligent Commands* changes Signed-off-by: David Festal <[email protected]>
What does this PR do?
This pull request is the second step of the work started in PR #4303.
More precisely:
Test
contextual menu, that sometimes used to hide the project-wide test menu entries for no clear reason.What issues does this PR fix or reference?
https://issues.jboss.org/browse/CHE-111
and more precisely the following sub-tasks:
https://issues.jboss.org/browse/CHE-148
https://issues.jboss.org/browse/CHE-149
https://issues.jboss.org/browse/CHE-154
https://issues.jboss.org/browse/CHE-157
Changelog
Java Testing support Bug fixes and Enhancements - Step 2
Release Notes
Testing support enhancements: