ARTIK-318: Add close to JGit clone operation #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinokurig
added
the
kind/bug
ghost
approved these changes
Mar 14, 2017
skabashnyuk
approved these changes
Mar 14, 2017
sleshchenko
approved these changes
Mar 14, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2173/ |
ghost
merged commit 
9 tasks
ghost
mentioned this pull request
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* ARTIK-318: Add close to JGit clone operation * fixup! ARTIK-318: Add close to JGit clone operation * fixup! ARTIK-318: Add close to JGit clone operation
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Jgit clone command is executed without close, Jgit process will capture
packfile in.gitfolder.As a result workspace folder is not deleted after deleting workspace in IDE on Windows OS.
What does this PR do?
Add
closeoperation to result of Jgit's clone command execution to free resources.What issues does this PR fix or reference?
https://github.com/codenvy/artik/issues/318
Changelog
Fix bug when workspace folder is not deleted after deleting workspace in IDE on Windows OS.
Release Notes
Bugfix N/A
Docs PR
Bugfix N/A