Improve eclipse ssh agent on unknown Linux stacks #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
TylerJewell
added
the
kind/enhancement
|
@lehmanju - thanks for the contribution. A maintainer will take a look and consider the details. Just to confirm, have you filled out the Eclipse CLA and signed your commit? It looks like the IP validation test is failing so far. |
|
@TylerJewell - I did sign the ECA on eclipse.org but the error still remains ... What do I have to do to fix that? Thx. |
|
Can you ammend the commit so that it contains the "Signed-off-by: Author Name [email protected]"? If you do this, the automatic validation should pick it up. |
…rying to execute sshd Signed-off-by: Julius Lehmann <[email protected]>
|
done |
Signed-off-by: Julius Lehmann <[email protected]>
TylerJewell
approved these changes
Mar 7, 2017
|
Fixed - thanks for your contribution! |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Fix issue where script is aborting on unknown Linux systems without trying to execute sshd Signed-off-by: Julius Lehmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It improves the situation on custom docker images using a Linux OS which is not listed explicitly in the ssh server script file. (SSH server agent)
Originally I wanted to run a custom docker image with Arch Linux installed (in Codenvy). Currently this does not work because Arch Linux is not supported as docker container. However, the script basically checks whether sshd works or not. On supported systems the package is installed automatically, if it does not work. On unsupported systems the script currently exits regardless of a working sshd server.
This change at least tries whether it works or not. If not, you can still exit with an error code.
Changelog
Improve behavior of SSH installation script on unknown Linux stacks