Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of temporary workspaces by schreduler instead of startup #14561

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Cleanup of temporary workspaces by schreduler instead of startup #14561

merged 5 commits into from
Sep 17, 2019

Conversation

mshaposhnik
Copy link
Contributor

What does this PR do?

Moves cleanup of temporary workspaces to be run on schredule instead of startup time. This will prevent intergiry errors because of uncontrolled @PostConstruct order and (optionally) speed up the startup.

What issues does this PR fix or reference?

#14525

Release Notes

N/A

Docs PR

N/A

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Sep 16, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14561

@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14561

@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14561

@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@mshaposhnik
Copy link
Contributor Author

ci-test

@mshaposhnik mshaposhnik requested review from mkuznyetsov and sparkoo and removed request for nickboldt, l0rd, rhopp and ibuziuk September 16, 2019 12:45
@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@mshaposhnik
Fix time unit
e1faae1 
Signed-off-by: Max Shaposhnik <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14561

skabashnyuk
skabashnyuk approved these changes Sep 16, 2019
View reviewed changes
...-workspace/src/main/java/org/eclipse/che/api/workspace/server/TemporaryWorkspaceRemover.java Outdated
@@ -43,7 +44,10 @@ public TemporaryWorkspaceRemover(WorkspaceDao workspaceDao, WorkspaceRuntimes ru
this.runtimes = runtimes;
}

@PostConstruct
@ScheduleDelay(
initialDelayParameterName = "che.workspace.cleanup_temporary_stopped_period_min",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use dedicated parameter for that che.workspace.cleanup_temporary_stopped_period_min -> che.workspace.cleanup_temporary_initial_delay_min

@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@che-bot
Copy link
Contributor

che-bot commented Sep 17, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14561

@che-bot
Copy link
Contributor

che-bot commented Sep 17, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@mshaposhnik mshaposhnik merged commit b8688de into master Sep 17, 2019
@mshaposhnik mshaposhnik deleted the temp_cleanup branch September 17, 2019 07:12
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 17, 2019
@che-bot che-bot added this to the 7.2.0 milestone Sep 17, 2019
@mshaposhnik mshaposhnik mentioned this pull request Sep 17, 2019
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparkoo sparkoo sparkoo approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@metlos metlos Awaiting requested review from metlos

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

@mkuznyetsov mkuznyetsov Awaiting requested review from mkuznyetsov

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mshaposhnik @che-bot @sparkoo @skabashnyuk