-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to create the che project multiple times if it was previously deleted. #13443
Attempt to create the che project multiple times if it was previously deleted. #13443
Conversation
deleted. Each attempt waits exponentially longer before retry. This should enable us to redeploy che using just a single invocation of deploy_che.sh. Signed-off-by: Lukas Krejci <[email protected]>
Does it fix #10409 ? |
Can you explain the issue (usecase) and the way how you fix it? In general. |
Yes, in a slightly different way than originally - the wait time exponentially increases between each attempt (which I'm not sure is ideal but it works)
The way to fix it is just to retry a couple of times. A first attempt is performed immediately, the second after 2 seconds, the third 4 seconds after that, the fourth 8 seconds after the third and the fifth 16 seconds after the fourth. |
I've seen this problem when just trying to use minishift in general; the time between a project being 'deleted' as in removed from visible projects to when all resources in the project are cleaned up can be significant. |
One comment:
Is it needed to increase waiting time between attempts? Maybe it would be more clear and simpler like wait for delete project 1 minute (check every few seconds 2-5). |
This ensures we don't wait unnecessarily long time at the later attempts where it is actually more likely that the attempt will (finally) succeed. Signed-off-by: Lukas Krejci <[email protected]>
…le-attempts Signed-off-by: Lukas Krejci <[email protected]>
ci-build |
Each attempt waits exponentially longer before retry.
This should enable us to redeploy che using just a single invocation of deploy_che.sh.