Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading devfiles from private repos other than GitHub/GitLab/Bitbucket/Azure #21951

Closed
Tracked by #21941
l0rd opened this issue Jan 25, 2023 · 5 comments
Closed
Tracked by #21941
Assignees
Labels
area/git/dev-environment-config Issues and PRs related to the automatic setup of git within a cloud development environment area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. roadmap/3-months Epics that are planned to complete in the short term (within 3 months) severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Jan 25, 2023

Is your enhancement related to a problem? Please describe

When the developer provides a private git repo HTTP URL (i.e. https://<che-host>/#<git-repo-http-url>), Eclipse Che looks for a devfile.yaml at the root of it and creates the corresponding DevWorkspace.

But that works only for GitHub, GitLab or Bitbucket and only if the git service has been previously configured (OAuth App or PAT). For other git services such as:

the devfile.yaml will be ignored the workspace will fail to start.

Describe the solution you'd like

Describe alternatives you've considered

Add OAuth and PAT support for other git services too.

Additional context

That's an issue for public repos too. But in the case of public repos there is a workaround. Instead of using the common workspace URL (https://<che-host>/#<git-repo-url>) the developer should use https://<che-host>/#<devfile-url>?remotes={<git-repo-url>}.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 25, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 25, 2023
@l0rd l0rd added area/git/dev-environment-config Issues and PRs related to the automatic setup of git within a cloud development environment area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 25, 2023
@l0rd
Copy link
Contributor Author

l0rd commented Feb 9, 2023

related Dev Spaces issue https://issues.redhat.com/browse/CRW-3927

@ibuziuk
Copy link
Member

ibuziuk commented Mar 1, 2023

@l0rd given that we now support azure and basic OAuth I believe in order to resolve this issue we need to still fix:

@l0rd
Copy link
Contributor Author

l0rd commented Mar 1, 2023

Resolving the devfile using the user git credentials or SSH key is important too (today we can only do that with the PAT).

But we can focus on those last 2 issues you mentioned, making things more stable and well documented, and use a separate issue for the resolver that uses git credentials or SSH key.

@ibuziuk ibuziuk added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. and removed kind/enhancement A feature request - must adhere to the feature request template. labels Mar 7, 2023
@ibuziuk ibuziuk mentioned this issue Mar 7, 2023
45 tasks
@ibuziuk ibuziuk mentioned this issue Mar 21, 2023
50 tasks
@l0rd
Copy link
Contributor Author

l0rd commented Jul 11, 2023

I have created the last issue #22356 (documentation) for this epic.
Note that devfile resolution in the case of SSH+GIT URLs has been moved to a separate issue (it had lower priority compared to the rest).

@l0rd l0rd added the roadmap/3-months Epics that are planned to complete in the short term (within 3 months) label Jul 11, 2023
@l0rd l0rd changed the title Support reading devfiles from private repos other than GitHub/GitLab/Bitbucket Support reading devfiles from private repos other than GitHub/GitLab/Bitbucket/Azure Oct 26, 2023
@l0rd l0rd assigned amisevsk and unassigned tolusha Nov 24, 2023
@l0rd
Copy link
Contributor Author

l0rd commented Jan 15, 2024

This issue has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git/dev-environment-config Issues and PRs related to the automatic setup of git within a cloud development environment area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. roadmap/3-months Epics that are planned to complete in the short term (within 3 months) severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants