Cannot create a factory from repository (without devfile) that has uppercase characters in name

[SkorikSergey]

Describe the bug

Cannot create a factory from repository(without devfile) that has uppercase characters in name.
There are restrictions:
Unable to create devworkspace: DevWorkspace.workspace.devfile.io "TestRepo" is invalid: metadata.name: Invalid value: "TestRepo": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

Che version

other (please specify in additional context)

Steps to reproduce

1. Try to create a factory from repository(without devfile) that has uppercase characters in name, for example from this - https://github.com/SkorikSergey/TestRepo.

Expected behavior

Workspace created and started successfully.

Suggested behaviour change is that the factory / devworkspace engine will sanitize the input GH repo name to make it compliant with OCP naming rules.

Runtime

OpenShift

Screenshots

Installation method

OperatorHub

Environment

Linux

Eclipse Che Logs

No response

Additional context

Eclipse Che 7.47.0

[nickboldt]

Suggested behaviour change is that the factory / devworkspace engine will sanitize the input GH repo name to make it compliant with OCP naming rules.

[nickboldt]

Also fails in dogfood cluster:

Dashboard Version 7.43.0-next
Server Version 7.47.0-SNAPSHOT
Username nickboldt
Browser Name chrome
Browser Version 100.0.4896
Browser OS Linux

Failed to create a workspace. 
Failed to create a new workspace from the devfile, reason: 
Failed to create a new workspace. Unable to create devworkspace: 
DevWorkspace.workspace.devfile.io "TestRepo" is invalid: metadata.name: 
Invalid value: "TestRepo": a lowercase RFC 1123 subdomain must consist of lower case 
alphanumeric characters, '-' or '.', and must start and end with an alphanumeric 
character (e.g. 'example.com', regex used for validation 
is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

[artaleks9]

Also this bug can be reproduced if customer devfile has ver. 1.0 and metadata with name in uppercase, e.g.

apiVersion: 1.0.0
metadata:
  name: testName

In this case we'll get the same error.
After fix the problem should check also this test case.

[nickboldt]

@SkorikSergey what happens with accented characters? Do we sanitize those already? Or break when French or Spanish or Arabic characters are used?

[SkorikSergey]

@nickboldt It is not possible to create repo with Arabic characters. And also with characters like ä, ö, ü.

[ibuziuk]

@l0rd wdyt should the fix be part of 3.0 ?

[l0rd]

This is not a blocker because it's a corner case: there is no devfile, the repo name has uppercase letters. But if it's an easy fix and there is no risk to postpone the release let's include that.

[ibuziuk]

Fixed in eclipse-che/che-dashboard#527