-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Devfile v2 outer loop components of type image
and kubernetes
#21186
Comments
from the architectural point of view, I would like to avoid adding more complexity to the dashboard and making it the "glue" / pre-processing component without which some of the DevWorkspace flows would not work (like in this particular case with the |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
/remove-lifecycle stale |
Added to #17883 |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
/remove-lifecycle stale |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Is your enhancement related to a problem? Please describe
Che currently ignores these component types although they are used in registry.devfile.io samples.
👉 Note that this issue is only about the “outer loop” implementation of these components. Outer loop means that the components are created after a workspace start-up to test in a prod like deployment. There is a separate issue for inner loop support.
A component is considered “outer loop” if any of these conditions apply (c.f. https://github.com/devfile/library/pull/127/files):
apply
deployByDefault: false
(the version of the spec is 2.2 or higher)autoBuild: true
) (the version of the spec is 2.2 or higher)Describe the solution you'd like
Pre-process the Devfile to replace the outer loop component with an
exec
command:kubernetes
oropenshift
components are replaced with akubectl apply
oroc apply
command in the dev componentimage
components are replaced with a command that does a build, in this case the command is configurable as there are multiple options likebuildah
,kaniko
,docker build
oroc start-build
on OCP.2 alternative approaches
The “outer loop” components replacement with
exec
commands can be a responsibility of the dashboard OR of the IDEs.Plus if it’s done by the dashboard: it works for any IDE
Plus if it’s done by the IDEs: it works for scenarios without Che dashboard (i.e.
k apply -f devworkspace.yaml
)The text was updated successfully, but these errors were encountered: