Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-registry] Specifying memoryRequest, cpuRequest, cpuLimit to the plugins #18485

Closed
4 tasks
ibuziuk opened this issue Nov 30, 2020 · 3 comments
Closed
4 tasks
Labels
area/plugin-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Nov 30, 2020

Is your task related to a problem? Please describe.

Currently memoryRequest, cpuRequest and cpuLimit are not set for the plugins in the plugin registry.

Describe the solution you'd like

Each plugin should specify not only memoryLimit, but also:

  • memoryRequest,
  • cpuRequest
  • cpuLimit

Additional context

List of plugins:

Draft PR - https://github.com/eclipse/che-plugin-registry/pull/471/files

@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/plugin-registry labels Nov 30, 2020
@ibuziuk ibuziuk changed the title [plugin-registry] memoryRequest, cpuRequest and cpuLimit are not set for the plugins [plugin-registry] Specifying memoryRequest, cpuRequest, cpuLimit to the plugins Nov 30, 2020
@ericwill
Copy link
Contributor

ericwill commented Dec 1, 2020

I think we can use #16685 for this, is that okay with you @ibuziuk?

@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 2, 2020

@ericwill #16685 does not have the memory request part

@ericwill
Copy link
Contributor

ericwill commented Dec 2, 2020

@ericwill #16685 does not have the memory request part

Now it does! Closing this ticket in favour of #16685

@ericwill ericwill closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants