Added docker buildx support in cico #483
Conversation
prabhav-thali
requested review from
benoitf,
ericwill,
vinokurig and
vitaliy-guliy
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
prabhav-thali
force-pushed
the
cico-buildx
branch
4 times, most recently
from
9304760 to
c8631b7
Compare
prabhav-thali
force-pushed
the
cico-buildx
branch
from
c8631b7 to
16b270a
Compare
prabhav-thali
force-pushed
the
cico-buildx
branch
2 times, most recently
from
870d510 to
3af3349
Compare
Signed-off-by: Prabhav Thali <[email protected]>
prabhav-thali
force-pushed
the
cico-buildx
branch
from
3af3349 to
7899f5a
Compare
|
@prabhav-thali can you rebase your PR please? |
prabhav-thali
force-pushed
the
cico-buildx
branch
from
0073103 to
81d5898
Compare
|
@ericwill I have updated the PR. |
|
Thanks! The PR appears to be a failing the shellcheck -- can you take a look? |
|
as ci.centos.org is being shut-downed before end the year I would not add new stuff there. |
|
@benoitf Thanks for the clarification. Could you please let us know whats your plan after ci.centos.org sunset and how we can enable s390x support to Che docker images? |
|
@prabhav-thali moving to github actions with buildx support |
|
As the cico scripts are no longer being maintained (centos CI is EOL), this PR will never be merged. Instead, please submit a new PR with code that calls a PLATFORMS file and runs buildx like this: https://github.com/eclipse/che-plugin-registry/blob/master/.ci/sidecar-build-publish.sh#L31-L35 See also:
PR to move to GH action in plugin registry: |
Signed-off-by: Prabhav Thali [email protected]
What does this PR do?
Adds docker buildx support in cico scripts to build multi-arch images.