This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Added docker buildx support in cico scripts #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditijadhav38
requested review from
benoitf,
ericwill,
JPinkney,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Can one of the admins verify this patch? |
aditijadhav38
force-pushed
the
buildx-ci-support
branch
2 times, most recently
from
360df98 to
add0c2d
Compare
|
You need to fix shell check: https://github.com/eclipse/che-devfile-registry/pull/250/checks?check_run_id=762136014 |
aditijadhav38
force-pushed
the
buildx-ci-support
branch
2 times, most recently
from
5733ef2 to
dc9465f
Compare
|
You almost fixed shell check. I think you can also use online validation using https://www.shellcheck.net It returns result very similar to our CI. |
aditijadhav38
force-pushed
the
buildx-ci-support
branch
from
dc9465f to
fa376cd
Compare
aditijadhav38
force-pushed
the
buildx-ci-support
branch
2 times, most recently
from
cf73428 to
ec2dcb7
Compare
Signed-off-by: Aditi Jadhav <[email protected]>
aditijadhav38
force-pushed
the
buildx-ci-support
branch
from
ec2dcb7 to
6c81d58
Compare
sparkoo
pushed a commit
to sparkoo/che-devfile-registry
that referenced
this pull request
Dec 4, 2020
…che#250) eclipse-che/che#14837 it allows to have Camel K Yaml file support Signed-off-by: Aurélien Pupier <[email protected]>
|
As the cico scripts are no longer being maintained (centos CI is EOL), this PR will never be merged. Instead, please submit a new PR with code that calls a PLATFORMS file and runs buildx like this: or like this: See also:
PR to move to GH action in plugin registry: |
This was referenced Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added docker buildx support in cico scripts