Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make callback closures provide mutable loaned structs #647

Closed
DenisBiryukov91 opened this issue Sep 11, 2024 · 0 comments · Fixed by #653
Closed

Make callback closures provide mutable loaned structs #647

DenisBiryukov91 opened this issue Sep 11, 2024 · 0 comments · Fixed by #653
Assignees
@sashacmc
Labels
release Part of the next release

Comments

@DenisBiryukov91
Copy link
Contributor

DenisBiryukov91 commented Sep 11, 2024 •
edited
Loading

Describe the release item

Make callback closures provide mutable loaned structs.
This is to allow avoid an extra clone when z_take is implemented for mutable loans in the future, and avoid holding a const ref value, preventing mutable access to shared memory in zenoh-c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sashacmc sashacmc

Labels
release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove const from closure params ZettaScaleLabs/zenoh-pico
2 participants
@sashacmc @DenisBiryukov91