-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find better solution for guice circular proxy problem #2430
Comments
Signed-off-by: Christian Dietrich <[email protected]>
|
unfortunately QualifiedNameValueConverter seems to be api. |
Signed-off-by: Christian Dietrich <[email protected]>
|
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
|
Signed-off-by: Christian Dietrich <[email protected]>
|
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
potential pattern to solve cycle using "Provider" and stay api compatible
|
I’d think this is a treacherous compatibility. Users who inject a specialized implementation might potentially attempt to cast the value which is available as a protected field. I don’t think there is a safe solution to this without API breakage. |
upstream pr still is open |
no update |
oom is fixed in upstream guice. thus will close this one with reference to #2056 |
we have seen the guice 5 circular proxy problem again
the workaround does not seem to work in all cases
so we should find a permanent solution
google/guice#1510
eclipse/xtext-core#393 (comment)
The text was updated successfully, but these errors were encountered: