Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc error on deploy #546

Closed
laeubi opened this issue Jan 20, 2022 · 10 comments
Closed

Javadoc error on deploy #546

laeubi opened this issue Jan 20, 2022 · 10 comments
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented Jan 20, 2022

While deploying tycho to sonartype the following errors are printed to the log:

[ERROR] MavenReportException: Error while generating Javadoc: 
Exit code: 1 - error: module org.eclipse.osgi.compatibility.state reads package org.eclipse.core.runtime from both org.eclipse.equinox.common and org.eclipse.equinox.registry
error: module org.eclipse.tycho.embedder.shared reads package org.eclipse.core.runtime from both org.eclipse.equinox.common and org.eclipse.equinox.registry
error: module org.eclipse.equinox.common reads package org.eclipse.core.runtime from both org.eclipse.equinox.registry and org.eclipse.equinox.common
error: module org.eclipse.equinox.registry reads package org.eclipse.core.runtime from both org.eclipse.equinox.common and org.eclipse.equinox.registry
error: the unnamed module reads package org.eclipse.core.runtime from both org.eclipse.equinox.registry and org.eclipse.equinox.common

Command line was: /usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc @options @packages
@mickaelistria
Copy link
Contributor

what's the command that triggers that? I don't remember we usually publish Maven reports and Javadoc (only mojo doc).

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

I use as described here: https://github.com/eclipse/tycho/blob/master/devdoc/Releasing_Tycho.md

mvn clean deploy -Prelease -DforgeReleaseId=sonatype-nexus-staging -DforgeReleaseUrl=https://oss.sonatype.org/service/local/staging/deploy/maven2/ -DskipTests

The deploy seems to ignore the errors but its a bit annoying (there are much more errors like this),

@laeubi laeubi mentioned this issue Jan 21, 2022
25 tasks
@cdietrich
Copy link
Contributor

can you check https://stackoverflow.com/questions/58836862/jdk-11-and-javadoc
it may be at least a workaround

@laeubi
Copy link
Member Author

laeubi commented Jan 21, 2022

@mickaelistria do you remember if such workarounds where necessary for the 2.5.0 deploy? I think we are using Java 11 for a while so I'm a bit confused.

@cdietrich
Copy link
Contributor

is the javadoc missing for all or a specific jar only?

@laeubi
Copy link
Member Author

laeubi commented Jan 21, 2022

I have updated the instructions here now: 000276c

@mickaelistria
Copy link
Contributor

do you remember if such workarounds where necessary for the 2.5.0 deploy?

Nope, however I never ever verified the log for Javadoc related messages, I just never cared enough, as long as the published content was correct.

@cdietrich
Copy link
Contributor

hmm if there is no javadoc jar created, nexus will complain.
or does it complain about the contents of the jar?

@mickaelistria
Copy link
Contributor

hmm if there is no javadoc jar created, nexus will complain.

Apparently, it doesn't prevent from pushing to OSSRH and then Central, we don't have javadoc in Maven Central for Tycho in 2.5.0: https://repo.maven.apache.org/maven2/org/eclipse/tycho/tycho-maven-plugin/2.5.0/

@laeubi
Copy link
Member Author

laeubi commented Jan 21, 2022

I'll close this as I adjusted the docs (no errors/warnings anymore) and javadoc seems optional.

@laeubi laeubi closed this as completed Jan 21, 2022
@laeubi laeubi added this to the 2.7 milestone Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants