Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deployment notes #560

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix: Deployment notes #560

merged 1 commit into from
Jul 4, 2023

Conversation

tuncaytunc-zf
Copy link
Contributor

WHAT

Fix deployment notes

WHY

The deployments notes were showing wrong information

FURTHER NOTES

Closes #514

@tuncaytunc-zf tuncaytunc-zf added the bug Something isn't working label Jul 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tuncaytunc-zf tuncaytunc-zf added the helmcharts Anything that has to do with helm charts label Jul 4, 2023
paullatzelsperger
paullatzelsperger approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paullatzelsperger paullatzelsperger merged commit b76e65e into eclipse-tractusx:main Jul 4, 2023
paullatzelsperger pushed a commit that referenced this pull request Jul 4, 2023
@tuncaytunc-zf @paullatzelsperger
Fix deployment notes. (#560)
af2c017
paullatzelsperger pushed a commit to paullatzelsperger/tractusx-edc that referenced this pull request Jul 4, 2023
@tuncaytunc-zf @paullatzelsperger
Fix deployment notes. (eclipse-tractusx#560)
674f42e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

@wolf4ood wolf4ood Awaiting requested review from wolf4ood

Assignees
No one assigned
Labels
bug Something isn't working helmcharts Anything that has to do with helm charts
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm deployment note includes faulty code
2 participants
@tuncaytunc-zf @paullatzelsperger