Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the NegotiateEdrRequestDto structure #936

Closed
ndr-brt opened this issue Dec 15, 2023 · 3 comments · Fixed by #1135
Closed

Update the NegotiateEdrRequestDto structure #936

ndr-brt opened this issue Dec 15, 2023 · 3 comments · Fixed by #1135
Assignees
@saschaisele-zf
Labels
enhancement New feature or request refactoring Refactoring, does not add functionality triage all new issues awaiting classification

Comments

@ndr-brt
Copy link
Contributor

ndr-brt commented Dec 15, 2023

WHAT

Currently the NegotiateEdrRequestDto structure follows the former shape of the ContractRequest object in upstream, using the ContractOfferDescription object (that's now deprecated).
Maybe we should follow the path charted on upstream: eclipse-edc/Connector#3395

WHY

avoid data duplication in the api

HOW

FURTHER NOTES

Please be sure to take a look at
our contribution guidelines and
our PR etiquette.
@ndr-brt ndr-brt added enhancement New feature or request refactoring Refactoring, does not add functionality triage all new issues awaiting classification labels Dec 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 4 weeks with no activity.

@github-actions github-actions bot added the stale label Jan 17, 2024
@ndr-brt
Copy link
Contributor Author

ndr-brt commented Jan 17, 2024 •
edited
Loading

there is still some discussion goin' on: International-Data-Spaces-Association/ids-specification#192
so this issue depend on the IDS one

EDIT: I commented on the wrong issue apparently 😅

@ndr-brt ndr-brt removed the stale label Jan 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 4 weeks with no activity.

@github-actions github-actions bot added the stale label Feb 19, 2024
@wolf4ood wolf4ood removed the stale label Feb 19, 2024
@saschaisele-zf saschaisele-zf self-assigned this Feb 29, 2024
@saschaisele-zf saschaisele-zf moved this from Open to In Progress in EDC Board Feb 29, 2024
@saschaisele-zf saschaisele-zf mentioned this issue Mar 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in EDC Board Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saschaisele-zf saschaisele-zf

Labels
enhancement New feature or request refactoring Refactoring, does not add functionality triage all new issues awaiting classification
Projects
EDC Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(api): Update NegotiateEdrRequestDto saschaisele-zf/tractusx-edc
3 participants
@wolf4ood @ndr-brt @saschaisele-zf