Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adoption request: Azure Blob extension as part of the core tractusx-edc build #639

Closed
1 of 2 tasks
ank19 opened this issue Jul 21, 2023 · 2 comments
Closed
1 of 2 tasks
Labels
enhancement New feature or request

Comments

@ank19
Copy link

ank19 commented Jul 21, 2023


name: Adoption Request
about: Submit your feature to the project
title: 'Adoption Request'
labels: 'adoption'
assignees: ''


Adoption Request

Thank you for wanting to contribute to the project! We are very happy to see the functionalities of the EDC being extended. Providing this open-source is a great opportunity for others with similar requirements and to avoid additional work.

For any details about the guidelines for submitting features, please take a look at the contribution categories.

General information

Please provide some information about your project or code contribution.

If you choose to be referenced as a "friend", these will be added to the known friends list.
If you choose to add your feature as a core EDC component, links to your current code and correlated issues, discussions, and pull requests are of great importance.

Title Description Contact Links
Integration of Azure Data Lake Azure Storage Blob extension as part of an offical build [email protected] Although the code is ready to be contributed, a link to repository or a PR can be provided after a pending internal approval. The forked component is https://github.com/eclipse-edc/Technology-Azure/tree/main/extensions/data-plane/data-plane-azure-storage

Adoption level

Next, please tell us what level of adoption you intend to provide. (pick only one)

  • Reference a feature as "friend"
  • Incorporate a feature as core EDC component

Adoption in EDC core

If you chose to add your feature as a core EDC component, please answer the following questions.

Why should this contribution be adopted?

Please argue why this feature must be hosted upstream and be maintained by the EDC core team.
The foundation or core feature is already maintained by the EDC core team, but it is not part of the official tractusx-edc build. As it is a) required that each providing business partner has to have this extension in order to be able to write to a consumer's data lake (provider transfers data without involvement of consumer data plane) and b) it is not straightforward to deploy extensions, having the Azure Blob extension as part of the official tractusx-edc repo is essential to be able to use it.

Could it be achieved with existing functionality? If not, why?

If there is any existing code that can achieve the same thing with little modification, that is usually the preferable way for the EDC core team. We aim to keep the code succinct and want to avoid similar/duplicate code. Make sure you understand the EDC code base well!
Yes, the change is only about including the existing Azure Blob Storage extension into the official tractusx-edc build.

Are there multiple use cases or applications who will benefit from the contribution?

Basically, we want you to motivate who will use that feature and why, thereby arguing the fact that it is well-suited to be adopted in the core code base. One-off features are better suited to be maintained externally.
As this contribution will help every company integrating the EDC on Azure, it is most likely that multiple use cases and application will benefit from this change.

Can it be achieved without introducing third-party dependencies? If not, which ones?

EDC is a platform rather than an application, therefore we are extremely careful when it comes to introducing third party libraries. The reasons are diverse: security, license issues and over all JAR weight, just to mention a few important ones.
No, it cannot be achieved without third-party dependencies, but these dependencies are already part of the official "Technology_Azure" repository.

Would this feature limit platform independence in any way? If so, how and why?

Features that do not work well in clustered environments are difficult to adopt, since EDC is designed from the ground up to be stateless and clusterable. Similarly, features, that have dependencies onto certain operating systems are difficult to argue.
This question does not apply, as the nature of this change wants to address a specific platform.

Is it going to be a self-contained feature, or would it cut across the entire code base?

Features that have a large impact on the code base are very complex to thoroughly test, they have a high chance to destabilize the code and require careful inspection. Self-contained features on the other hand are easier to isolate and test.
The feature is self-contained as an extension.

@ank19 ank19 added the enhancement New feature or request label Jul 21, 2023
@saschaisele-zf
Copy link
Contributor

Hello,
Azure Blob Storage was integrated with #755 and released in 0.6.0-rc1.

@github-project-automation github-project-automation bot moved this from Open to Done in EDC Board Oct 17, 2023
@ank19
Copy link
Author

ank19 commented Oct 23, 2023

@saschaisele-zf - Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants