Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication between cloud-transfer-tests and end2end-transfer-test #1630

Closed
ndr-brt opened this issue Oct 17, 2024 · 0 comments · Fixed by #1635
Closed

Remove duplication between cloud-transfer-tests and end2end-transfer-test #1630

ndr-brt opened this issue Oct 17, 2024 · 0 comments · Fixed by #1635
Assignees
@ndr-brt
Labels
refactoring Refactoring, does not add functionality triage all new issues awaiting classification

Comments

@ndr-brt
Copy link
Contributor

ndr-brt commented Oct 17, 2024

WHAT

These two modules appear to have a similar scope, because they contains similar classes used to set up transfers.

WHY

Duplication is bad

HOW

They could in fact be included in the same module because at the end they are all "transfer" tests, and the ones in cloud-transfer-tests could involve also control-plane (now they're only testing data-plane)

FURTHER NOTES

// anything else you want to outline

Please be sure to take a look at
our contribution guidelines and
our PR etiquette.
@ndr-brt ndr-brt added refactoring Refactoring, does not add functionality triage all new issues awaiting classification labels Oct 17, 2024
@ndr-brt ndr-brt self-assigned this Oct 17, 2024
@ndr-brt ndr-brt mentioned this issue Oct 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from Open to Done in EDC Board Oct 18, 2024
@ndr-brt ndr-brt mentioned this issue Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndr-brt ndr-brt

Labels
refactoring Refactoring, does not add functionality triage all new issues awaiting classification
Projects
EDC Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: extract e2e-fixtures module Think-iT-Labs/tractusx-edc
1 participant
@ndr-brt