Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

published jars contain test dependencies #1462

Closed
ndr-brt opened this issue Jul 25, 2024 · 0 comments · Fixed by #1463
Closed

published jars contain test dependencies #1462

ndr-brt opened this issue Jul 25, 2024 · 0 comments · Fixed by #1463
Assignees
Labels
enhancement New feature or request triage all new issues awaiting classification

Comments

@ndr-brt
Copy link
Contributor

ndr-brt commented Jul 25, 2024

WHAT

Looking at a fat jar like edc-controlplane-postgresql-azure-vault, it contain edc.junit artifact and its dependencies, like testcontainers, this is caused by the fact that some of our extensions are declaring edc.junit as an api/implementation dependency instead of the correct testImplementation.
This is causing the jar artifact to be around 78MB instead of 50MB.

WHY

// outlines the motivation, why the feature is desired, and possibly what the impact is if the feature is not
implemented. "Because we need it" is not a sufficient reason!

HOW

// if possible, outlines a solution proposal

FURTHER NOTES

// anything else you want to outline

Please be sure to take a look at
our contribution guidelines and
our PR etiquette.

@ndr-brt ndr-brt added enhancement New feature or request triage all new issues awaiting classification labels Jul 25, 2024
@ndr-brt ndr-brt self-assigned this Jul 25, 2024
@github-project-automation github-project-automation bot moved this from Open to Done in EDC Board Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage all new issues awaiting classification
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant