Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDC 0.7.1 → Wrong URLs in Walkthrough and Swagger? #1315

Closed
jerzy-wachowiak opened this issue May 17, 2024 · 1 comment · Fixed by #1359
Closed

EDC 0.7.1 → Wrong URLs in Walkthrough and Swagger? #1315

jerzy-wachowiak opened this issue May 17, 2024 · 1 comment · Fixed by #1359
Labels
documentation Improvements or additions to documentation

Comments

@jerzy-wachowiak
Copy link

https://github.com/eclipse-tractusx/tractusx-edc/blob/main/docs/usage/management-api-walkthrough/07_edrs.md

Is:

POST /v2/edrs HTTP/1.1
Host: https://consumer-control.plane/api/management
X-Api-Key: password
Content-Type: application/json

Should be:

POST /v2/edrs HTTP/1.1
Host: https://consumer-control.plane/management
X-Api-Key: password
Content-Type: application/json

etc.

https://app.swaggerhub.com/apis/eclipse-tractusx-bot/tractusx-edc/0.7.1#/EDR%20Cache/requestEdrEntries

Is
/v1/edrs/request:

Should be:
/v2/edrs/request:
etc

@jerzy-wachowiak jerzy-wachowiak added bug Something isn't working triage all new issues awaiting classification labels May 17, 2024
@wolf4ood
Copy link
Contributor

Hi @jerzy-wachowiak

thanks for raising this

The first issue depends on how you actually configure the management api to be exposed. So the
https://consumer-control.plane/api/management is just an example the relevant part is /v2/edrs but i guess is fine to change it also.

The second issue for the EDR api there are two versions, one from upstream EDC which tractusx does not use it (your link)

and the extension of those API for supporting refresh which is available here

The issue is that the swagger doc of tractusx includes also the upstream EDC one and thus it contains both APIs, even if the upstream one is not used/imported.

@wolf4ood wolf4ood added documentation Improvements or additions to documentation and removed bug Something isn't working triage all new issues awaiting classification labels Jun 13, 2024
@github-project-automation github-project-automation bot moved this from Open to Done in EDC Board Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants