Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Autocomplete API allows to only show results which exists in a sublist of data (e.g. edit notification affected parts) #859

Closed
ds-mwesener opened this issue Apr 16, 2024 · 4 comments · Fixed by #942, catenax-ng/tx-traceability-foss#1250 or catenax-ng/tx-traceability-foss#1254
Assignees
Labels
backend Backend related issues frontend Frontend related Issues public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path spillover temporary label for spill over

Comments

@ds-mwesener
Copy link
Contributor

ds-mwesener commented Apr 16, 2024

As ... ,
I want ... ,
so that ... .

Hints / Details

  • ...

Acceptance Criteria

  • While editing or creating a notification the autocomplete displays only suggestion based on the data which is available in the table.
  • Frontend sets the affectedPartIds in the distinctFilterValues api request as input parameter (Autocomplete API)
  • Backend accepts a list of asset ids within the AutoComplete API to allow additional filtering.

Out of Scope

  • ...
@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented May 7, 2024

This feature will be merged in tx-backend in the main branch with #942

ds-mwesener pushed a commit that referenced this issue May 7, 2024
ds-mwesener added a commit that referenced this issue May 7, 2024
…-autocomplete-api

feature: #859 enable autocomplete API to filter for given assets
@ds-lcapellino ds-lcapellino moved this from wip to test in Trace-X May 8, 2024
@ds-mwesener ds-mwesener assigned ds-crehm and unassigned ds-lcapellino May 8, 2024
@ds-mwesener ds-mwesener moved this from test to wip in Trace-X May 8, 2024
@mkanal mkanal added the spillover temporary label for spill over label May 14, 2024
@mkanal mkanal reopened this May 14, 2024
@ds-mwesener ds-mwesener added R24.5 release-hot-fix pbi is relevant for current release and for hotfix path labels May 14, 2024
@ds-mwesener ds-mwesener moved this from wip to test in Trace-X May 15, 2024
@ds-crehm
Copy link
Contributor

Tested on E2E-A & E2E-B:
The autocomplete filter only shows results found in the current table. That works as intended.
However, the filter is not updated when changing the table in any way.

Searching for 'urn' in the table shows only the expected results at first:
grafik

However, when I add all the parts to the 'Affected parts' table, the filter is not reset and still shows the previous results.
grafik

Same happens when I change from investigation to alert. Now the table only shows Own parts but when I open the filter I still have the old filter.
grafik

Resetting the filter manually works and then the updated list is shown.

@ds-crehm
Copy link
Contributor

ds-crehm commented May 15, 2024

Tested on dev & test now:
Autocomplete filter still shows only the results found from the current table. Additionally the filter is now reset whenever there was a change to the table contents.

Filter shows every result at first:
image

After changing the table, the results are reset. The input is unchanged:
image

Only after changing the input again the application shows an updated set of results:
image

@ds-crehm ds-crehm reopened this May 15, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X May 15, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm May 15, 2024
ds-jhartmann pushed a commit that referenced this issue May 22, 2024
…ubset-of-data

chore(bug): #859 reset suggestions when filter closed
@mkanal
Copy link
Contributor

mkanal commented Jun 5, 2024

LGFM: PO acceptance in behalf of @jzbmw

@mkanal mkanal moved this from review to done in Trace-X Jun 5, 2024
@mkanal mkanal added the public public and not spammy label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues frontend Frontend related Issues public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path spillover temporary label for spill over
Projects
Status: done
4 participants