Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the newest IRS version #823

Closed
1 task
ds-lcapellino opened this issue Apr 3, 2024 · 7 comments
Closed
1 task

Migrate to the newest IRS version #823

ds-lcapellino opened this issue Apr 3, 2024 · 7 comments
Assignees

Comments

@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented Apr 3, 2024

As Developer,
I want to migrate to the newest IRS version,
so that I can also migrate to the newest Registry version for Release 24.05.

Links

Hints / Details

-irs-helm version must be upgraded from 6.9.1 to 6.18.0

Acceptance Criteria

  • TraceX uses the latest IRS version

Out of Scope

  • ...
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Apr 3, 2024
@mkanal mkanal moved this from inbox to backlog in Trace-X Apr 3, 2024
@mkanal mkanal moved this from backlog to next in Trace-X Apr 4, 2024
@ds-lcapellino ds-lcapellino self-assigned this Apr 4, 2024
@mkanal
Copy link
Contributor

mkanal commented Apr 4, 2024

@jzbmw as this blocks #636 I have added this to the sprint scope.

@ds-lcapellino ds-lcapellino moved this from next to wip in Trace-X Apr 4, 2024
@ds-lcapellino
Copy link
Contributor Author

Because of the IRS changes in 4.8.0:
Registering a job - aspects array is now accepting full urn of aspect model instead of name only, eg. 'urn:bamm:io.catenax.single_level_bom_as_built:2.0.0#SingleLevelBomAsBuilt' instead 'SingleLevelBomAsBuilt'. #439
We have to downgrade to urn:bamm:io.catenax.single_level_bom_as_built:1.0.0#SingleLevelBomAsBuilt.
IRS can not process such aspects, becuase this version is not present in the semantic hub.

@ds-lcapellino ds-lcapellino moved this from wip to test in Trace-X Apr 5, 2024
@ds-lcapellino
Copy link
Contributor Author

  • TraceX uses the latest IRS version
    No new functionality added, this is implicitly tested.

@ds-mwesener
Copy link
Contributor

Currently the e2e tests failing because of the implementation of the story. The e2e tests using a global asset with a relation to
urn:bamm:io.catenax.single_level_usage_as_built:2.0.0#SingleLevelUsageAsBuilt

See log on trace-x b when trying to resolve the relationship object which is needed for a successfull notification within the e2e tests.

org.springframework.web.client.HttpClientErrorException$BadRequest: 400 null: "{"statusCode":"BAD_REQUEST","error":"Aspects did not match the available aspects: '[urn:bamm:io.catenax.single_level_usage_as_built:2.0.0#SingleLevelUsageAsBuilt]'","messages":null}"

@ds-lcapellino please find an efficient way how we can deal with this. E2E Tests red is not acceptable.

Thank you

@ds-mwesener ds-mwesener moved this from test to wip in Trace-X Apr 10, 2024
@ds-lcapellino
Copy link
Contributor Author

This PR: catenax-ng#1157 will downgrade SingeLevelUsageAsBuilt to 1.0.0. Because 2.0.0 is not yet in the Semantic Hub.

@ds-mwesener
Copy link
Contributor

Hi @ds-lcapellino please create a new issue which will also adapt our data import controller. Currently it is accepting also the 2.0.0.

@ds-crehm
Copy link
Contributor

Not possible to test. E2E tests are working again. Ready for review.

@ds-crehm ds-crehm assigned jzbmw and unassigned ds-lcapellino and ds-crehm Apr 12, 2024
@jzbmw jzbmw moved this from review to done in Trace-X Apr 15, 2024
@jzbmw jzbmw closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

5 participants