Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DashboardController has missing @PreAuthorize condition regarding Rights and Role Matrix #726

Closed
poojapatel23 opened this issue Mar 5, 2024 · 2 comments · Fixed by catenax-ng/tx-traceability-foss#1188 or catenax-ng/tx-traceability-foss#1200
Assignees
Labels
bug Something isn't working external Issues with external requestors

Comments

@poojapatel23
Copy link

poojapatel23 commented Mar 5, 2024

Description

Trace-X API handles three roles: 'User' and 'Supervisor' and 'Admin'. Most of APIS are protected/Authorization by some roles.
As per my understanding, DashboardController has handles by all three roles and should be defined @PreAuthorize condition for it.

Link : https://catenax-ng.github.io/tx-traceability-foss/docs/administration/administration-guide.html#_rights_and_role_matrix_of_trace_x

Current behavior

Missing @PreAuthorize condition for DashboardController
Screenshot 2024-03-05 at 13 07 15

Expected behavior

Should be defined @PreAuthorize condition for DashboardController
Screenshot 2024-03-05 at 13 09 12

@github-project-automation github-project-automation bot moved this to inbox in Trace-X Mar 5, 2024
@mkanal mkanal added the bug Something isn't working label Mar 14, 2024
@mkanal
Copy link
Contributor

mkanal commented Mar 14, 2024

Approved during Open Meeting

@jzbmw jzbmw added the external Issues with external requestors label Mar 19, 2024
@RazvanZmau RazvanZmau moved this from inbox to backlog in Trace-X Mar 19, 2024
@mkanal mkanal moved this from backlog to next in Trace-X Apr 16, 2024
@ds-mwesener ds-mwesener removed their assignment Apr 16, 2024
@ds-mmaul ds-mmaul moved this from next to wip in Trace-X Apr 18, 2024
@ds-mmaul ds-mmaul self-assigned this Apr 18, 2024
@ds-mmaul ds-mmaul moved this from wip to test in Trace-X Apr 18, 2024
@ds-mmaul ds-mmaul moved this from test to wip in Trace-X Apr 18, 2024
@ds-mmaul ds-mmaul moved this from wip to test in Trace-X Apr 22, 2024
@ds-crehm
Copy link
Contributor

Not possible to test. Looks good to me. PreAuthorize annotation is now added for the DashboardController.
Ready for review.

@ds-crehm ds-crehm reopened this Apr 25, 2024
@ds-crehm ds-crehm assigned jzbmw and unassigned ds-mmaul Apr 25, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X Apr 25, 2024
@jzbmw jzbmw closed this as completed Apr 30, 2024
@jzbmw jzbmw moved this from review to done in Trace-X Apr 30, 2024
@mkanal mkanal reopened this Apr 30, 2024
@mkanal mkanal closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issues with external requestors
Projects
Status: done
6 participants