Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance use case participant get credential endpoint by supporting filters #331

Conversation

leandro-cavalcante
Copy link
Contributor

@leandro-cavalcante leandro-cavalcante commented Feb 6, 2025

Description

The purpose of this feature is to enhance the functionality of the existing GET /api/issuer/useCaseParticipation endpoint in the Issuer Component. The enhancement involves the ability to filter the returned list of use case participations by the status of the credentials (Active, Expired, or All).

Why

Instead of always returning all use case credentials it gives the customer the power of retrieving it by status.

Issue

NA

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@leandro-cavalcante leandro-cavalcante changed the title Feature/enhance use case participant get credential endpoint by supporting filters feat: enhance use case participant get credential endpoint by supporting filters Feb 6, 2025
@leandro-cavalcante leandro-cavalcante force-pushed the feature/Enhance-useCaseParticipant-GET-Credential-endpoint-by-supporting-filters branch from 4fd0374 to 1bf1f1e Compare February 6, 2025 14:57
…t-filters' into feature/Enhance-useCaseParticipant-GET-Credential-endpoint-by-supporting-filters
@leandro-cavalcante
Copy link
Contributor Author

@evegufy the PR #297 is closed. I open this new PR with the changes needed for this feature. Please consider this one now.

@evegufy evegufy requested review from Phil91 and evegufy February 7, 2025 08:03
@evegufy evegufy added this to the Release 25.03 milestone Feb 7, 2025
@Phil91
Copy link
Member

Phil91 commented Feb 7, 2025

@leandro-cavalcante please add reviewers the next time you create a pr

@leandro-cavalcante
Copy link
Contributor Author

@leandro-cavalcante please add reviewers the next time you create a pr

Sure, next time I do that.

@Phil91 Phil91 merged commit 2996a7c into eclipse-tractusx:main Feb 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants