From 98d980d2fd5f5c1ce40287bb342f163608981f1b Mon Sep 17 00:00:00 2001 From: "Aggarwal Sahil (BCI/ESW17)" Date: Fri, 17 Nov 2023 16:03:59 +0100 Subject: [PATCH] updated samm cli version to 2.3.2 --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- .github/workflows/governance.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1f0c4e35..c190010c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,7 +8,7 @@ Closes # ## MS2 Criteria (to be filled out by PR reviewer) -- [ ] the model **validates** with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar samm-cli.jar aspect \ validate ). The SAMM CLI is available [here](https://eclipse-esmf.github.io/esmf-developer-guide/tooling-guide/samm-cli.html) and in [GitHub](https://github.com/eclipse-esmf/esmf-sdk/releases/tag/v2.3.1) +- [ ] the model **validates** with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar samm-cli.jar aspect \ validate ). The SAMM CLI is available [here](https://eclipse-esmf.github.io/esmf-developer-guide/tooling-guide/samm-cli.html) and in [GitHub](https://github.com/eclipse-esmf/esmf-sdk/releases/tag/v2.3.2) - [ ] use **Camel-Case** (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case) - [ ] the identifiers for all model elements **start with a capital letter** except for properties - [ ] the identifier for **properties starts with a small letter** diff --git a/.github/workflows/governance.yml b/.github/workflows/governance.yml index b6e16ba8..0823ae5e 100644 --- a/.github/workflows/governance.yml +++ b/.github/workflows/governance.yml @@ -85,7 +85,7 @@ jobs: uses: ./.github/actions/model-validation with: pr_number: ${{ github.event.number }} - bamm_version: 2.3.1 + bamm_version: 2.3.2 added: ${{needs.synchronize-models.outputs.ADDED}} modified: ${{needs.synchronize-models.outputs.MODIFIED}} - name: Archive