Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Update]: BatteryPass correction input #81

Open
5 of 6 tasks
catroest opened this issue Feb 21, 2023 · 4 comments
Open
5 of 6 tasks

[Model Update]: BatteryPass correction input #81

catroest opened this issue Feb 21, 2023 · 4 comments
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.

Comments

@catroest
Copy link
Contributor

catroest commented Feb 21, 2023

Update Reason

  1. Copy-Paste Mistake, property has the wrong preferred name resulting in false documentation in the semantic hub.
    entity: electrochemical properties entity
    property: batteryPower

  2. description states the property as a "characteristic"

  3. Component suppliers --> spare part supplier

MS1 Criteria

  • The model that should be updated exists
  • The referenced use case exists
  • The potential updates are discussed with all stakeholders
  • The potential update will be either
    • backward compatible or
    • a (chain of) migration strategy(-ies) from all non-deprecated previous versions to the new model will be developed
@ZazraltMagic
Copy link

  • [ok] model exists
  • [ok] UC: CE
  • [ok] patch update
  • [ok] backward compatible (nothing changed)

MS1 approved
@bs-jokri

@bs-jokri
Copy link
Contributor

@catroest don't forget to update the model version.

@bs-jokri bs-jokri added the MS1_Approved Checklist "MS1 Request for Model Developement" is approved. label Mar 13, 2023
@catroest
Copy link
Contributor Author

@bs-jokri update on hold until there is a bigger/new update, then this issue will be implemented in the other/new issue/pr

@catroest catroest changed the title [Model Update]: BatteryPass wrong preferred name [Model Update]: BatteryPass correction input Mar 16, 2023
@bs-jokri
Copy link
Contributor

@catroest is this resolved or do we need to leave it open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.
Projects
None yet
Development

No branches or pull requests

3 participants