Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Update]: PartAsPlanned 3.0.0 #566

Closed
6 of 8 tasks
johannsvarela opened this issue Jan 26, 2024 · 4 comments
Closed
6 of 8 tasks

[Model Update]: PartAsPlanned 3.0.0 #566

johannsvarela opened this issue Jan 26, 2024 · 4 comments
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.

Comments

@johannsvarela
Copy link
Contributor

johannsvarela commented Jan 26, 2024

Update Reason

Based on the continous development of the Industry Core, there are a new data, that needs to be integrated in the PartAsPlanned aspect model:

^\d{4}-\d{2}-\d{2}(T\d{2}:\d{2}:\d{2}(\.\d{1,6})?(Z|[+-]\d{2}:\d{2}))?$

Relevant Standards

  • CX-0126 Industry Core: Part Type 2.0.0 (if merged before 29.02.24)

Example Data

{
  "catenaXId": "580d3adf-1981-44a0-a214-13d6ceed9379",
  "partTypeInformation": {
    "manufacturerPartId": "123-0.740-3434-A",
    "nameAtManufacturer": "Mirror left",
    "partClassification": [
      {
        "classificationStandard": "IEC",
        "classificationID": "61360- 2:2012 ",
        "classificationDescription": "Standard data element types with associated classification scheme for electric components."
      }
    ]
  },
  "partSitesInformationAsPlanned": [
    {
      "functionValidUntil": "0558-65-61T42:39:64+69:77",
      "catenaXsiteId": "BPNS1234567890ZZ",
      "function": "production",
      "functionValidFrom": "8343-44-37T24:99:37.51527Z"
    }
  ]
}

MS1 Criteria

  • The model that should be updated exists
  • The referenced use case exists
  • The potential updates are discussed with all stakeholders
  • A decision on versioning was made in consensus with the affected parties according to the guidelines.
  • The potential update will be either
    • backward compatible or
    • a (chain of) migration strategy(-ies) from all non-deprecated previous versions to the new model will be developed
  • A modeling steward has been assigned
@agg3fe agg3fe added the MS1_Approved Checklist "MS1 Request for Model Developement" is approved. label Jan 29, 2024
@johannsvarela
Copy link
Contributor Author

@agg3fe @catroest Since we want to rename the PartAsPlanned aspect model, this issue can be closed / set deprecate and therefore will be replaced by a new issue: [New Model]: PartTypeInformation 1.0.0 #591

@tomaszbarwicki @jonbckr @BenediktMuellerIML FYI

@agg3fe
Copy link
Contributor

agg3fe commented Feb 1, 2024

@johannsvarela should I close this issue and PR #567 , both?

@johannsvarela
Copy link
Contributor Author

@johannsvarela should I close this issue and PR #567 , both?

Yes! :)

@agg3fe
Copy link
Contributor

agg3fe commented Feb 1, 2024

closing as renaming would be required for the model.
Since we want to rename the PartAsPlanned aspect model, this issue can be closed / set deprecate and therefore will be replaced by a new issue: [New Model]: PartTypeInformation 1.0.0 #591

@agg3fe agg3fe closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants