Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Update]: io.catenax.shared.message_header V.2.0.0 #469

Closed
6 of 8 tasks
jonbckr opened this issue Nov 20, 2023 · 6 comments · Fixed by #476
Closed
6 of 8 tasks

[Model Update]: io.catenax.shared.message_header V.2.0.0 #469

jonbckr opened this issue Nov 20, 2023 · 6 comments · Fixed by #476
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.

Comments

@jonbckr
Copy link
Contributor

jonbckr commented Nov 20, 2023

Update Reason

We want to correct the current message header model (e.g. Traits) so it is semantically correct.

MS1 Criteria

  • The model that should be updated exists
  • The referenced use case exists
  • The potential updates are discussed with all stakeholders
  • A decision on versioning was made in consensus with the affected parties according to the guidelines.
  • The potential update will be either
    • backward compatible or
    • a (chain of) migration strategy(-ies) from all non-deprecated previous versions to the new model will be developed
  • A modeling steward has been assigned
@jonbckr
Copy link
Contributor Author

jonbckr commented Nov 20, 2023

FYI @johannsvarela @BenediktMuellerIML

@agg3fe
Copy link
Contributor

agg3fe commented Nov 23, 2023

Is this new model backward compatible with existing version? If not, then it would make sense to create new model with major version change, v2.0.0

@BenediktMuellerIML
Copy link
Contributor

BenediktMuellerIML commented Nov 23, 2023

Is this new model backward compatible with existing version? If not, then it would make sense to create new model with major version change, v2.0.0

We talked about it and will do a v2.0.0.

@johannsvarela
Copy link
Contributor

johannsvarela commented Nov 23, 2023

@agg3fe Since our colleague - who created this issue - is on vacation for the next two weeks, we can't adapt this issue. Therefore we can offer you to create a new Issue, so that you can close this one. What's your opinion?

@agg3fe
Copy link
Contributor

agg3fe commented Nov 23, 2023

@agg3fe Since our colleague - who created this issue - is on vacation for the next two weeks, we can't adapt this issue. Therefore we can offer you to create a new Issue, so that you can close this one. What's your opinion?

if only change is changing the version, I can also do that if you want. If there is any other change also, then we create new one.

@johannsvarela
Copy link
Contributor

@agg3fe Since our colleague - who created this issue - is on vacation for the next two weeks, we can't adapt this issue. Therefore we can offer you to create a new Issue, so that you can close this one. What's your opinion?

if only change is changing the version, I can also do that if you want. If there is any other change also, then we create new one.

@agg3fe then lets keep this issue and you only change the title for us :-) We will link the PR to fix the bug soon.

@agg3fe agg3fe changed the title [Model Update]: io.catenax.shared.message_header V.1.0.1 [Model Update]: io.catenax.shared.message_header V.2.0.0 Nov 23, 2023
@agg3fe agg3fe added the MS1_Approved Checklist "MS1 Request for Model Developement" is approved. label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants