Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Deprecation]: urn:bamm:io.catenax.week_based_material_demand:1.0.1 #387

Open
3 tasks
bs-jokri opened this issue Oct 6, 2023 · 5 comments
Open
3 tasks
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.

Comments

@bs-jokri
Copy link
Contributor

bs-jokri commented Oct 6, 2023

Update Reason

The model is neither used in a standard document or triangle document, which indicates that the model is not used anymore.

If there are still reasons to still have this model in the repository, please provide a short rationale in the comments. If not, please indicate with a "+1" that you are OK with deprecating the model.

Deprecating a model means, that it will be removed after two Tractus-X releases from the repository. For details, please refer to the GOVERNANCE process.

MS1 Criteria

  • The model that should be deprecated exists and is not deprecated already
  • The respective model does not affect existing use cases (aspect is either used in higher versions or replaced by a different aspect)
  • A shared aspect, which will be deprecated, is not used by any released aspect model
@bs-jokri
Copy link
Contributor Author

bs-jokri commented Oct 6, 2023

@nhaenis please check this request

@nhaenis
Copy link
Contributor

nhaenis commented Oct 6, 2023

can be set to deprecated after release 24.03 - used in CX-0047 and CX-0048

@agg3fe
Copy link
Contributor

agg3fe commented Feb 1, 2024

@nhaenis since this model is written in Bamm, I will create a new model with major version upgrade by just converting this model from bamm to samm. is that fine for you?

@nhaenis
Copy link
Contributor

nhaenis commented Feb 1, 2024

@nhaenis since this model is written in Bamm, I will create a new model with major version upgrade by just converting this model from bamm to samm. is that fine for you?

yes of course - thank you!

@agg3fe
Copy link
Contributor

agg3fe commented Feb 2, 2024

PR created #595 for bamm to samm conversion.
In future if you want to make any updates, you can also make direct changes in this model since this is just a samm view of current model.

@agg3fe agg3fe added the MS1_Approved Checklist "MS1 Request for Model Developement" is approved. label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.
Projects
None yet
Development

No branches or pull requests

3 participants