Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Update]: Return Request #38

Closed
5 of 6 tasks
jonbckr opened this issue Jan 23, 2023 · 2 comments · Fixed by #65
Closed
5 of 6 tasks

[Model Update]: Return Request #38

jonbckr opened this issue Jan 23, 2023 · 2 comments · Fixed by #65
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.

Comments

@jonbckr
Copy link
Contributor

jonbckr commented Jan 23, 2023

Update Reason

  • Desired price: No description; unclear how desired price relates to a return request.
  • Last return data – Typo
  • Needs return – typo
  • Request data: talks about a date in GMT time zone. Is it a timestamp according to ISO 8601? Typically, timestamps are reference to UTC. Where would I find that definition?

MS1 Criteria

  • The model that should be updated exists
  • The referenced use case exists
  • The potential updates are discussed with all stakeholders
  • The potential update will be either
    • backward compatible or
    • a (chain of) migration strategy(-ies) from all non-deprecated previous versions to the new model will be developed
@mthiers
Copy link
Contributor

mthiers commented Jan 23, 2023

core team meeting:
bullet point 2. + 3. can not be found in currenty versions, no typos - comments obsolete (according to @kevin Tram)

bullet point 1. "Price the manufacturers are willing to pay for this part after EoL of a car."

bullet point 4. "Request data: talks about a date in GMT time zone. Is it a timestamp according to ISO 8601? Typically, timestamps are reference to UTC. Where would I find that definition?" --> change description to "Describes until when the request is valid."

MS1 approval given
(@bs-jokri will do postdocumentation)

@bs-jokri bs-jokri added the MS1_Approved Checklist "MS1 Request for Model Developement" is approved. label Jan 23, 2023
@mthiers
Copy link
Contributor

mthiers commented Jan 27, 2023

bullet point 1. "Price the manufacturers are willing to pay for this part after EoL of a car." -> @Kevinataccenture can not be found in most current version 1.1.1 (missing in semantic hub) therefore I assume this comment ist obsolete and can be ignored

bullet point 4. "Request data: talks about a date in GMT time zone. Is it a timestamp according to ISO 8601? Typically, timestamps are reference to UTC. Where would I find that definition?" --> change description to "Describes until when the request is valid." -> changed for request date and latest return date

@bs-jokri bs-jokri linked a pull request Feb 8, 2023 that will close this issue
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MS1_Approved Checklist "MS1 Request for Model Developement" is approved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants