Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the CSV upload of sites and addresses #948

Open
17 tasks
maximilianong opened this issue Oct 23, 2024 · 19 comments
Open
17 tasks

Optimize the CSV upload of sites and addresses #948

maximilianong opened this issue Oct 23, 2024 · 19 comments
Assignees
Labels
business partner Feature/Bug for Business Partner KIT portal Feature/Bug for Portal component Prep-R25.03
Milestone

Comments

@maximilianong
Copy link
Contributor

maximilianong commented Oct 23, 2024

Overview

The portal provides the option to upload sites and addresses for a legal entity via CSV.

#700

However, this page should be revised at certain points to make it easier for users to understand.

What's the benefit?

Companies can easily provide their site and address data, required for various use cases, to the data space via CSV upload. This allows them to contribute their own data to the Golden Record process without having to be a sharing member.

What are the Risks/Dependencies ?

BPDM team provided an API for this CSV upload.

Detailed explanation

Current implementation

#700

Proposed improvements

  • Status on provided records needs to be optimized
  • .. @Cofinity-UX will add more points

Feature Team

Contributor

Committer

User Stories

  • Issue 1, linked to specific repository
  • Issue 2, linked to another specific repository

Acceptance Criteria

  • Criteria 1
  • Criteria 2
  • Criteria 3

Test Cases

Test Case 1

Steps

  1. Do something
  2. Click something
  3. Add something

Expected Result

  1. Expectation
  2. Expectation
  3. Expectation

Architectural Relevance

The following items are ensured (answer: yes) after this issue is implemented:

Justification: (Fill this out, if at least one of the checkboxes above cannot be ticked. Contact the Architecture Management Committee to get an approval for the justification)

Additional information

  • I am aware that my request may not be developed if no developer can be found for it. I'll try to contribute a developer (bring your own developer)
@maximilianong maximilianong added portal Feature/Bug for Portal component business partner Feature/Bug for Business Partner KIT Prep-R25.03 labels Oct 23, 2024
@Cofinity-UX
Copy link

Cofinity-UX commented Oct 23, 2024

@maximilianong
Proposal for basic functionality, usability and wording fixes (I could not access the latest version of the reference implementation, maybe some points are already updated)
Kindly add me as Contributor in this ticket, thank you!

General structure of page:

  • Implementation of a headline, subline, text module as introduction and guidance for the adding address section (separation from My Company section). Concept, hierarchy and benefit of BPNL/S/A need to be communicated to users.
  • Order of buttons in table: Add site first, add address after (to reflect the structure of address level and order of table)
  • indicator that row element of table is clickable needs to be implemented (cursor should change into pointy hand)
  • If user wants to copy information out of the table (indicated by the text cursor), it should not open the detailed view
  • "1 row selected" information on the bottom of page is redundant
  • If the BPD logic suggests that addresses relate to sites/legal entity, this information should be displayed in the table. (Legal entity can be seen as "Main Site" and should be selectable for adding addresses to it)
  • Add Address: selection of site should be indicated by a dropdown field. If no site is available, the user should be enabled to create one
  • Country Code input field: too vage description, no validation (in Registration flow there is a selection of country code (based on country list))
  • Check refresh token of page, this might clear user input data after certain time
  • Where is BPNA or BPNS information shown in successfull added data?

UX writing updates:

Main page:

  • Title of navigation item + page headline "Company address data" (Company data is not accurate enough)
  • Wording of buttons don't correspond with opened modal (add address --> create new address)
  • Wording of table columns should align with standard wording (e.g.: location --> Address, Type --> BPN Type)
  • Status label "ready" is wrongly attributed with the action & icon. it needs to be updated accordingly to the process step (in review, pending etc..)
  • Status label "success" is not accurate enough, better: "validated" "verified"

Company Data Detail Modal:

  • Helpertext behind (?) should provide valuable information
  • Legal entity number = Business Partner Number (BPN)

Add Address/Site Modals:

  • Helptext behind (?) should not repeat the input field label names – provision of actual detail description of required input
  • Error texts in inputfields: generic repetition of inputfield label is no error text. Error text has to correspond with all validation types and possible errors. (Company data step in registration flow has validation of the inputfields implemented, why not here?)
  • Country identifier needs to be changed to Company identifier (country is the wrong term)

cc: @MaximilianHauer @ybidois

@Cofinity-UX
Copy link

Cofinity-UX commented Nov 5, 2024

Hi @SujitMBRDI,
can you explain what processes are happening in the background for the two status labels "pending" and "ready" (context: adding site data on Company Data page). Thank you!
Bildschirmfoto 2024-11-05 um 15 23 06
Bildschirmfoto 2024-11-05 um 15 23 18

cc: @maximilianong

@SujitMBRDI
Copy link
Contributor

Hi @SujitMBRDI, can you explain what processes are happening in the background for the two status labels "pending" and "ready" (context: adding site data on Company Data page). Thank you! Bildschirmfoto 2024-11-05 um 15 23 06 Bildschirmfoto 2024-11-05 um 15 23 18

cc: @maximilianong

Hello @Cofinity-UX,

The logic behind these two sharing state is as below,

Ready - When a sharing member uploads new business partner input data, the sharing member might not want to share this data immediately to the golden record process. The sharing member may perform additional checks on analysis on it first, prepare it further, before deciding it is fit to be shared.

Pending - After a sharing member has updated the business partner input data, the BPDM Gate should request a cleaning of the input data at the orchestrator. The orchestrator will create a new cleaning task and return its unique identifier to the requesting Gate. A Gate should then save the task identifier for its business partner data and update its sharing state.

@Cofinity-UX
Copy link

Hi @SujitMBRDI, thank you for clarifying.
Regarding the Ready status: right now, if I'm adding a site (Entry DEV (24.08)), the status goes automatically to pending.
Where is the functionality to actively share the site data to the Golden Record process?

@SujitMBRDI
Copy link
Contributor

Hi @SujitMBRDI, thank you for clarifying. Regarding the Ready status: right now, if I'm adding a site (Entry DEV (24.08)), the status goes automatically to pending. Where is the functionality to actively share the site data to the Golden Record process?

Hello @Cofinity-UX,

The functionality is totally depending on configuration you made while deploying application.
Here is link for you reference.
So, you can choose configurations as per the need like if you don't want business partner input data to directly ready to be shared then assign starts-as-ready to false likewise configurations can be changed.

@Cofinity-UX
Copy link

Cofinity-UX commented Nov 7, 2024

Hi @SujitMBRDI,
if a customer subscribes to an application or service, the expectation is that the functionality is ready to use. So what you are describing is a scenario where a technically skilled user sets up this configuration in the backend, did I get that correctly? There is neither the information beforehand that this configuration can/must be taken nor any UI to do this connected to the Company Data page in the Portal?

@maximilianong how is this configuration planned to face a customer?

@SujitMBRDI
Copy link
Contributor

SujitMBRDI commented Nov 8, 2024

Hi @SujitMBRDI, if a customer subscribes to an application or service, the expectation is that the functionality is ready to use. So what you are describing is a scenario where a technically skilled user sets up this configuration in the backend, did I get that correctly? There is neither the information beforehand that this configuration can/must be taken nor any UI to do this connected to the Company Data page in the Portal?

@maximilianong how is this configuration planned to face a customer?

Hello @Cofinity-UX,

I am not saying configuration planned to face a customer, you asked me to provide process which are happening in background. So as explained, due to default configuration on backend which is starts-as-ready set to true. It results when you add site then the status goes to automatically to Pending and after golden record process you will receive status as Success or Error.

@Cofinity-UX
Copy link

@SujitMBRDI
From a UX point of view I need to understand both, background processes which then affect the user interaction on touchpoint level. Since the user won't do the BE configuration, we (as provider of the service) need to decide, which configuration will be set in place, right?

If "starts-as-ready" is set to true, which interaction of the user will then set it to "pending"?

@SujitMBRDI
Copy link
Contributor

@SujitMBRDI From a UX point of view I need to understand both, background processes which then affect the user interaction on touchpoint level. Since the user won't do the BE configuration, we (as provider of the service) need to decide, which configuration will be set in place, right?

If "starts-as-ready" is set to true, which interaction of the user will then set it to "pending"?

@Cofinity-UX
Yes, you are right.

@stephanbcbauer
Copy link
Member

stephanbcbauer commented Nov 11, 2024

Some hints from Release Management (@ther3sa) and Tractus-X Project Lead (@stephanbcbauer)

  • Status currently in Inbox. ⇾ Only features with status backlog are considered in open planning
  • Please add committer
  • Please add assignee (overall responsible person who drives the feature)

@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Nov 11, 2024
@Cofinity-UX
Copy link

Hi @SujitMBRDI,
to determine with configuration to take for our customers, I still need to know:
If "starts-as-ready" is set to true, what (or which interaction of the user) needs to happen to set the status to "pending"?

@SujitMBRDI
Copy link
Contributor

Hi @SujitMBRDI, to determine with configuration to take for our customers, I still need to know: If "starts-as-ready" is set to true, what (or which interaction of the user) needs to happen to set the status to "pending"?

Hello @Cofinity-UX,
I suggest to setup meeting between us where i can provide you more details.
But anyways, my point is simple here considering interaction of user while sharing data is nothing to do with configuration that i explained to you(I explained the configuration for your understanding).
For User perspective -
Once user share data, it will be automatically part of golden record process and there are stages of sharing for user shared data. In simple words you can interpret stages like Ready - is the stage where data is already initialised and ready to share for golden record data processing and Pending - is stage where data is being processed for golden record once golden record process finish then sharing stage will be either Success(consider shared data has been accepted for golden record) or Error(here shared data has not been accepted by golden record and you will also get error message why it was not accepted).
Ideally, if you merge the both Ready and Pending sharing stages then you can say data is InProcess or InProgress something like that as both stages has very minimal difference in them.

@Cofinity-UX
Copy link

Totally agree @SujitMBRDI, a session is needed. I'll send you an invite for next week, anyone from your side who should join (@MaximilianHauer?)

@manojava-gk
Copy link

@Cofinity-UX add me to the list. would like to participate in the meeting

@stephanbcbauer
Copy link
Member

@maximilianong mentioned this feature needs still some kind of refinement

@stephanbcbauer
Copy link
Member

@MaximilianHauer mentioned -> Review by committer could be the problem. A lot todo

@evegufy evegufy moved this from NEW USER REQUEST to BACKLOG in Portal Nov 13, 2024
@stephanbcbauer
Copy link
Member

@evegufy mentioned to prioritize this feature as high (from portal side)

@evegufy
Copy link
Contributor

evegufy commented Nov 13, 2024

Acknowledging the fact that there is still refinement needed, Portal Committers:
@oyo
@ntruchsess
@Phil91
@evegufy

@stephanbcbauer stephanbcbauer added this to the 25.03 milestone Nov 13, 2024
@nicoprow nicoprow moved this to New in BPDM Kanban Dec 4, 2024
@ClosedSourcerer
Copy link

As discussed during the portal open meeting, I created the following issues:

eclipse-tractusx/portal-frontend#1404
eclipse-tractusx/portal-frontend#1403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
business partner Feature/Bug for Business Partner KIT portal Feature/Bug for Portal component Prep-R25.03
Projects
Status: New
Status: BACKLOG
Status: Backlog
Development

No branches or pull requests

7 participants