Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger UI inconsistent to current behavior for submodel controllers #515

Closed
tom-rm-meyer-ISST opened this issue Jul 23, 2024 · 0 comments · Fixed by #516
Closed

Swagger UI inconsistent to current behavior for submodel controllers #515

tom-rm-meyer-ISST opened this issue Jul 23, 2024 · 0 comments · Fixed by #516
Labels
bug Something isn't working

Comments

@tom-rm-meyer-ISST
Copy link
Contributor

Description

Current behaviour

During #514 we realized that the swagger ui often shows incorrect response bodies (e.g. return entity instead of empty).

All submodel api controllers are subject to this:

  • production-request-api-controller
  • demand-request-api-controller
  • item-stock-request-api-controller
    It may also make sense to add desccriptions to these controllers, that these are meant to be called by partners through the EDC.

Expected behavior

Swagger UI should be in line with the implementation

Steps to reproduce the Bug

  • build backend
  • run local deployment
  • open swagger-ui of customer
  • compare controller with backend implementation
@tom-rm-meyer-ISST tom-rm-meyer-ISST added the bug Something isn't working label Jul 23, 2024
@tom-rm-meyer-ISST tom-rm-meyer-ISST linked a pull request Jul 24, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant