Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig#779 - Inconsistent page names #696

Closed
oyo opened this issue Apr 10, 2024 · 3 comments
Closed

sig#779 - Inconsistent page names #696

oyo opened this issue Apr 10, 2024 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@oyo
Copy link
Contributor

oyo commented Apr 10, 2024

Current Behavior

Longer page names follow inconsistent naming conventions:

Expected Behavior

Page names should follow a consistent naming convention

Steps To Reproduce

Open the definitions of the page names:
https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/types/Constants.ts#L25-L107
Check the name values - also some constant keys are inconsinstent like: APPRELEASEPROCESS and APP_RELEASE_PROCESS_FORM

@oyo oyo added the bug Something isn't working label Apr 10, 2024
@oyo oyo added this to Portal Apr 10, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Apr 10, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal May 30, 2024
@manojava-gk manojava-gk self-assigned this Jun 19, 2024
@manojava-gk manojava-gk moved this from BACKLOG to IN PROGRESS in Portal Jun 19, 2024
@msinamci msinamci moved this from IN PROGRESS to BACKLOG in Portal Jun 20, 2024
@manojava-gk manojava-gk moved this from BACKLOG to IN PROGRESS in Portal Jun 21, 2024
@evegufy evegufy added this to the Release 24.08 milestone Jul 5, 2024
@manojava-gk manojava-gk moved this from IN PROGRESS to IN REVIEW in Portal Jul 11, 2024
@evegufy
Copy link
Contributor

evegufy commented Jul 23, 2024

@manojava-gk @oyo this issue is in status in review, why are no pull requests linked?

@manojava-gk
Copy link
Contributor

@manojava-gk @oyo this issue is in status in review, why are no pull requests linked?

Its already merged

image

@evegufy evegufy modified the milestones: Release 24.12, Release 2.2.0 Aug 5, 2024
@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Aug 26, 2024
@MaximilianHauer MaximilianHauer moved this from USER READY to IN PROGRESS in Portal Aug 26, 2024
@github-project-automation github-project-automation bot moved this from IN PROGRESS to USER READY in Portal Aug 26, 2024
@evegufy evegufy changed the title Inconsistent page names sig#779 - Inconsistent page names Sep 23, 2024
@typecastcloud
Copy link
Contributor

Hi @evegufy, are you already considering changes in helm values for PR #895 ?

Most camel case changes do not make a difference but something like consent_osp -> consentOsp is breaking the OSP path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants