[ 20º ] - Release/v2.1.0 frontend agree: Frontend policy decline/agree functionality #206
Conversation
…-opt Feature/cmp 950/contract sign opt
Integration/v2.1.0: Frontend policy decline/agree functionality
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9408211 | Triggered | Generic High Entropy Secret | a79919c | src/store/index.js | View secret |
| 9408211 | Triggered | Generic High Entropy Secret | d11b85a | src/store/index.js | View secret |
| 9408211 | Triggered | Generic High Entropy Secret | ea216db | src/store/index.js | View secret |
| 9408211 | Triggered | Generic High Entropy Secret | cc7e7c6 | src/store/index.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
matbmoser
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.github/workflows/trivy.yml
Outdated
|
|
||
| - name: Upload Trivy scan results to GitHub Security tab | ||
| if: always() | ||
| uses: github/codeql-action/upload-sarif@v2 | ||
| uses: github/codeql-action/upload-sarif@v3 |
Check notice
Code scanning / KICS
Unpinned Actions Full Length Commit SHA Note
.github/workflows/trivy.yml
Outdated
|
|
||
| - name: Upload Trivy scan results to GitHub Security tab | ||
| if: always() | ||
| uses: github/codeql-action/upload-sarif@v2 | ||
| uses: github/codeql-action/upload-sarif@v3 |
Check notice
Code scanning / KICS
Unpinned Actions Full Length Commit SHA Note
.github/workflows/trivy.yml
Outdated
|
|
||
| - name: Upload Trivy scan results to GitHub Security tab | ||
| uses: github/codeql-action/upload-sarif@v2 | ||
| uses: github/codeql-action/upload-sarif@v3 |
Check notice
Code scanning / KICS
Unpinned Actions Full Length Commit SHA Note
Dockerfile
Outdated
| @@ -62,15 +63,15 @@ | |||
| HEALTHCHECK NONE | |||
|
|
|||
| # add permissions for a user | |||
| RUN chown -R 10000:3000 /app && chmod -R 775 /app/ | |||
| RUN chown 10000:3000 /entrypoint.sh && chmod -R 775 /entrypoint.sh | |||
| RUN chown -R 1000:3000 /app && chmod -R 775 /app/ | |||
Check notice
Code scanning / KICS
Multiple RUN, ADD, COPY, Instructions Listed Note
matbmoser
force-pushed
the
release/v2.1.0-frontend-agree
branch
from
5eb7ae2 to
a458abd
Compare
matbmoser
force-pushed
the
release/v2.1.0-frontend-agree
branch
from
a458abd to
abe3799
Compare
|
Revised and no secrets are there..... The token is not a secret is a session token that expires and this ones in concrete are not real secrets |
Why we create this PR?
Users should have the option to choose a contract/policy or decline the passport reciving process
What we want to achieve with this PR?
We want to display available contracts and available policies for the user.
Users can choose one and continue receiving the passport or decline and cancel getting the passport.
What is new?
Added