Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRG 7.03] Clarify if an extra IP check for project content is needed at the end of the release #95

Closed
matbmoser opened this issue Jul 18, 2023 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@matbmoser
Copy link
Contributor

matbmoser commented Jul 18, 2023

Introduction

We need to clarify if we need to do a second IP check on our project content.
It was performed in the last quality gate but we don't know if it needs to be performed again

@matbmoser matbmoser changed the title TRG 7.03 IP checks for project content [TRG 7.03] Clarify if a second IP check for project content is needed Jul 18, 2023
@matbmoser matbmoser added the documentation Improvements or additions to documentation label Jul 18, 2023
@matbmoser matbmoser self-assigned this Jul 18, 2023
@matbmoser matbmoser changed the title [TRG 7.03] Clarify if a second IP check for project content is needed [TRG 7.03] Clarify if a extra IP check for project content is needed Jul 18, 2023
@matbmoser matbmoser changed the title [TRG 7.03] Clarify if a extra IP check for project content is needed [TRG 7.03] Clarify if a extra IP check for project content is needed at the end of the release Jul 18, 2023
@matbmoser
Copy link
Contributor Author

matbmoser commented Jul 18, 2023

I investigated about it and the short answer is "NO, an extra IP check is not required".

The explanation for that is the following:

There is a statement in the TRGs that state the following and applys for PRs:

Contributions made by Eclipse Tractus-X committers do not require review by the Eclipse IP Team and can be pushed directly into a project repository.

All the pull requests and new content that was added to the Tractus-X repository was merged by a commiter since the first IP check for the project made for the initial code contribution.

All the contributors signed the ECA and there is a requirement for that:

Contributions by Eclipse contributors (signed ECA) must be received via an Eclipse Foundation channel (e.g., GitHub pull request, attachment on an issue)

The PRs were revised in detail and me as a member from the core development team from this application can confirm that the code was 100% developed from scratch from us. I can also confirm that the DEPENDENCIES OSS checks are being made regularly and are always done before merging any PR that contains changes in the pom.xml or in any packege.json or packege-lock.json.

This requirement is already full filled and this issue can be closed.

@matbmoser matbmoser changed the title [TRG 7.03] Clarify if a extra IP check for project content is needed at the end of the release [TRG 7.03] Clarify if an extra IP check for project content is needed at the end of the release Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant