Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration option missing in values file #234

Closed
hzierer opened this issue Feb 20, 2024 · 3 comments · Fixed by #235
Closed

configuration option missing in values file #234

hzierer opened this issue Feb 20, 2024 · 3 comments · Fixed by #235
Assignees
Milestone

Comments

@hzierer
Copy link
Contributor

hzierer commented Feb 20, 2024

Hey,

as states in our TRG 5.06 some additional values should be configurable in the values.yaml. I did not check all, but at least these two are missing:

  • ingress class
  • Persistent storage configuration

Additionally TRG 5.08 demands that all variables are present, got default values and got comments what they are doing

@matbmoser
Copy link
Contributor

@hzierer is it enough that we update that in the main branch?

@hzierer
Copy link
Contributor Author

hzierer commented Feb 20, 2024

sure, as long as you add it to future development branches too

@matbmoser
Copy link
Contributor

Ok sure

@matbmoser matbmoser moved this from Planning to Work in progress in Digital Product Pass Feb 20, 2024
@matbmoser matbmoser added this to the v2.1.3 milestone Feb 20, 2024
@matbmoser matbmoser removed their assignment Feb 20, 2024
@github-project-automation github-project-automation bot moved this from Work in progress to Done in Digital Product Pass Feb 20, 2024
@matbmoser matbmoser mentioned this issue Feb 20, 2024
83 tasks
@matbmoser matbmoser added PI13 and removed PI13 labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants