-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QG 4] Clarify Chart testing #122
Comments
Hi @SebastianBezold, We basically used the workflow provided by the TRGs. The EDC consumer should be working and we check for this if the configuration is correct. |
About the PVC: For running the Container in the Github workflows we need a PV instance. Therefore we copy and paste the PV inside the workflow file system to enable it to work. If you would run it in local or in another environment the PV would not be needed. |
Finally the helm tests work. https://github.com/eclipse-tractusx/digital-product-pass/actions/runs/5868393507 digital-product-pass/charts/digital-product-pass/values.yaml Lines 141 to 145 in 6fcafbe
|
Hi @matbmoser, the original issue seems to be fixed, but the app is still not starting due to other startup config evaluation it seems: run via: install dpp tractusx-dev/digital-product-pass --version 1.0.0-rc3 --namespace dpp --create-namespace Error:
|
To call the Discovery Service after the correct startup is an achitecture requirement for us to get the endpoint of the BPN Discovery and the EDC Discovery. The same way that the EDC breaks if you have not added a correct configuration. And there is no problem with that. |
The requirement is documented here: digital-product-pass/docs/arc42/Arc42.md Line 168 in 6fcafbe
|
Ok @SebastianBezold the issue with the dash tool has been resolved and the images have been published. The new v1.0.0 version created from the release candidate rc4 contains the fix for this issue. |
|
Description
Looking at the runs for Lint and Test Charts, you can see, that all of the runs are failing. The only successful runs skip "Run chart-testing" and "Run helm upgrade".
Looking at the workflow itself, I can also see some copy/paste of PVC manifests that I cannot see a reason for.
Also, wenn installing the latest Chart (version
1.0.0
), it's running in a crash loop. Installed via:Results in a couple of restarts, but ending in Errors containing this hing:
If this is a malformed sample value, I think the default should be replace by a correctly formatted value. If it is a startup check, that could also be done on runtime (reachability test of remote service), then I would suggest to change this test to a runtime evaluation. The TRG 5.01 Description does point out, that Charts should be installable without any config and at least start without issues.
This should be clarified, before the QG 4 check #108 is marked as passed
The text was updated successfully, but these errors were encountered: