Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency check between Gate and Pool #1130

Open
3 tasks
StWeisshaar opened this issue Nov 26, 2024 · 3 comments
Open
3 tasks

Consistency check between Gate and Pool #1130

StWeisshaar opened this issue Nov 26, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request standards-relevant The issue has an impact on the Catena-X standards

Comments

@StWeisshaar
Copy link

StWeisshaar commented Nov 26, 2024

Description

As user of BPDM,
I would like that the BPNs shown in the Gate Output Stage are consistent with the BPNs stored in the Pool,
so that the information stored in the Gate can be trusted.

Acceptance Criteria

  • Consistency check between Gate Output Stage and Pool
  • Error sharing state type to inform users about inconsistencies
  • Configurable schedule for the consistency check

Additional Information

There are currently no endpoints to remove issued BPNs from the Pool. In the case of duplicates we must delete them directly from the Pool DB. Making sure that these BPNs are not only removed from the Pool but also from the Gates is error prone and should be supported by a consistency check from the Gate. Especially for de-centralized Gates it makes sense to have a consistency check in place that can validate the stored BPNs. We must make sure that this feature does not open a backdoor to fetch information about all existing BPNs.

@StWeisshaar StWeisshaar added the enhancement New feature or request label Nov 26, 2024
@nicoprow nicoprow added this to the BPDM v6.3.0 / R25.03. milestone Nov 26, 2024
@nicoprow nicoprow added the standards-relevant The issue has an impact on the Catena-X standards label Nov 26, 2024
@nicoprow nicoprow moved this to New in BPDM Kanban Dec 4, 2024
@nicoprow nicoprow moved this from New to 📋 Backlog in BPDM Kanban Dec 6, 2024
@nicoprow
Copy link
Contributor

@StWeisshaar I assign you this issue to drive it to a refined state. Let's talk about it in the next refinement meeting and see if we can already put it to the refined state. For now , I have no more questions towards that topic and I could see it being worked on.

@SujitMBRDI what is your opinion?

@nicoprow
Copy link
Contributor

Note: there is already a sharing state error called 'BpnNotInPool'. I would suggest to use that one.

@SujitMBRDI
Copy link
Contributor

@StWeisshaar I assign you this issue to drive it to a refined state. Let's talk about it in the next refinement meeting and see if we can already put it to the refined state. For now , I have no more questions towards that topic and I could see it being worked on.

@SujitMBRDI what is your opinion?

Yes, I can agree for the two topics in acceptance criteria those are as below.

  1. Consistency check between Gate Output Stage and Pool -> No doubts, development wise it is clear.
  2. Configurable schedule for the consistency check -> No doubts.

But for the topic Error sharing state type to inform users about inconsistencies, we have already sharing states error which are defining inconsistencies e.g. BpnErrorNotFound and BpnErrorTooManyOptions. Also, we can configure BpnNotInPool to make it more consistent.
or are we expecting separate sharing state api endpoint where user(sharing member) can feed in BPNs for which consistency should be checked?

@maximilianong maximilianong moved this from 📋 Backlog to 🔖 Refined in BPDM Kanban Dec 11, 2024
@maximilianong maximilianong moved this from 🔖 Refined to 📋 Backlog in BPDM Kanban Dec 11, 2024
@nicoprow nicoprow moved this from 📋 Backlog to 🔖 Refined in BPDM Kanban Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request standards-relevant The issue has an impact on the Catena-X standards
Projects
Status: 🔖 Refined
Development

No branches or pull requests

3 participants