Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: Support property SourceControlInputBox#visible #11348

Closed

Conversation

KevinK-9
Copy link
Contributor

What it does

Implements Support specifying whether an SourceControlInputBox is visible.

Issues Adressed

How to test

  • ToDo

Review checklist

Reminder for reviewers

@KevinK-9 KevinK-9 marked this pull request as draft June 27, 2022 10:18
@KevinK-9 KevinK-9 changed the title feat(scm): add visibility variable in plugin API vscode: Support property SourceControlInputBox#visible Jun 27, 2022
@vince-fugnitto
Copy link
Member

@KevinK-9 thank you for the contribution, do you need help with testing?

@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility scm issues related to the source control manager labels Jul 7, 2022
@xai
Copy link
Contributor

xai commented Jul 7, 2022

For testing, I tried to create a simple vscode extension.

To test, install the test extension vscode-extension-sourcecontrol-inputbox-11140-0.0.1.vsix in your theia workspace from your filesystem.
It provides a command SourceControlInputBox: Status to display the properties of sourceControl.inputBox.
(It also provides SourceControlInputBox: Hide and SourceControlInputBox: Show to change the respective Boolean.)

Using the patch from this PR (I rebased it on current master though), theia behaves the same as VSCode, at least in my setup.

@xai
Copy link
Contributor

xai commented Jul 12, 2022

@vince-fugnitto I suggest we close this in favor of #11412, which includes the working patch (thanks @KevinK-9!) and a respective sample extension for testing. If there are any additional requirements to get Kevin's patch in, I will gladly take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] Support property SourceControlInputBox#visible
3 participants