Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Concept of "Execution" for Tasks #9333

Open
tsmaeder opened this issue Apr 13, 2021 · 0 comments
Open

Introduce Concept of "Execution" for Tasks #9333

tsmaeder opened this issue Apr 13, 2021 · 0 comments
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

Many problems (#8822, https://github.com/eclipse-theia/theia/pull/8756/files#r525950124, etc.) seem to be caused by the fact that we don't have the concept of "Execution" (as in ProcessExecution, ShellExecution) in Theia. Instead, we rely solely on the task type to determine which TaskRunner to use for a particular task. So we end up with two "task type" fields, namely type and taskType. This leads to code that is hard to understand, maintain and test.

Feature Description:

I would introduce the the concept of "execution" into the Task system (in TaskConfiguration, for example) and use that to choose a task runner. The task type would then remain static and we could have a single type field for tasks. The current mechanism of registering a task runner for a particular task type should remain for compatibility reasons at this moment and could be deprecated over time.

@tsmaeder tsmaeder added tasks issues related to the task system vscode issues related to VSCode compatibility labels Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

1 participant