Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align location field of ProgressOptions with VS Code #8703

Closed
RomanNikitenko opened this issue Nov 3, 2020 · 0 comments · Fixed by #8700
Closed

Align location field of ProgressOptions with VS Code #8703

RomanNikitenko opened this issue Nov 3, 2020 · 0 comments · Fixed by #8700
Assignees
@RomanNikitenko
Labels
plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Milestone
1.8.0

Comments

@RomanNikitenko
Copy link
Contributor

At the moment it's possible to use ProgressLocation enum only as a location at which progress should show.
The goal is aligning location field to the corresponding field of VS Code to provide an opportunity to use viewId as progress location.

Additional Information

There is a PR #8700, the solution works for main views (at least explorer, debug, search and scm), but doesn't work for a custom view inside a custom view container: #8700 (comment).
@azatsarynnyy azatsarynnyy mentioned this issue Nov 3, 2020
Closed
16 tasks
@azatsarynnyy azatsarynnyy added the Team: Che-Editors issues regarding the che-editors team label Nov 3, 2020
@azatsarynnyy azatsarynnyy added vscode issues related to VSCode compatibility plug-in system issues related to the plug-in system labels Nov 3, 2020
@azatsarynnyy azatsarynnyy added this to the 1.8.0 milestone Nov 3, 2020
@RomanNikitenko RomanNikitenko mentioned this issue Nov 12, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanNikitenko RomanNikitenko

Labels
plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Use 'viewId' as progress location eclipse-theia/theia
2 participants
@azatsarynnyy @RomanNikitenko