Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickpickInput / canPickMany result #6557

Closed
benoitf opened this issue Nov 15, 2019 · 3 comments · Fixed by #6558
Closed

QuickpickInput / canPickMany result #6557

benoitf opened this issue Nov 15, 2019 · 3 comments · Fixed by #6558
Labels
bug bugs found in the application vscode issues related to VSCode compatibility

Comments

@benoitf
Copy link
Contributor

benoitf commented Nov 15, 2019

Description

When using QuickPickInput, if canPickMany flag is given
https://github.com/microsoft/vscode/blob/1876ce6361634423d0d5534b12dad1270c1373ff/src/vs/vscode.d.ts#L1630

It should always return an array as result

note: it does not provide multiple selection support, just comply with expected result.

Reproduction Steps

Trying extension using canPickMany and expecting array result is failing. (like result.forEach)

Diagnostics:

@benoitf benoitf added bug bugs found in the application vscode issues related to VSCode compatibility labels Nov 15, 2019
@vince-fugnitto
Copy link
Member

I believe it is not supported yet #5673. Is it a duplicate?

@benoitf
Copy link
Contributor Author

benoitf commented Nov 15, 2019

@vince-fugnitto it's not to support the display, just to make compliant the result that should be an array.
It's like avoiding crash

@vince-fugnitto
Copy link
Member

@vince-fugnitto it's not to support the display, just to make compliant the result that should be an array.
It's like avoiding crash

Thanks I understand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants