Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] ignoreFocusOut option is not respected for InputBox and QuickPick #5882

Closed
tetchel opened this issue Aug 7, 2019 · 5 comments · Fixed by #5900
Closed

[vscode] ignoreFocusOut option is not respected for InputBox and QuickPick #5882

tetchel opened this issue Aug 7, 2019 · 5 comments · Fixed by #5900
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@tetchel
Copy link
Contributor

tetchel commented Aug 7, 2019

Whether showQuickPick or createQuickPick (or InputBox) is used, I see the same behaviour; it is as though this property is not set / set to false.

https://code.visualstudio.com/api/references/vscode-api#QuickPickOptions
https://code.visualstudio.com/api/references/vscode-api#InputBoxOptions

@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility labels Aug 8, 2019
@akosyakov
Copy link
Member

@vinokurig @JPinkney do you think you can have a look into it?

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Aug 8, 2019
@vinokurig
Copy link
Contributor

@tetchel this should be fixed by #5900, could you please test

@tetchel
Copy link
Contributor Author

tetchel commented Aug 9, 2019

I verified #5900 works for QuickPick, thanks for that.

But InputBox needs the same change, so please don't close this until we have both.

@vinokurig
Copy link
Contributor

@tetchel It should already work with InputBox, I've tested it by modifying the input-box action in the vscode quick-input sample. Could you please try to insert ignoreFocusOut: true, after this line: https://github.com/microsoft/vscode-extension-samples/blob/5fb626a4e383c41b8878f94045cff987b92b6bca/quickinput-sample/src/basicInput.ts#L26

@tetchel
Copy link
Contributor Author

tetchel commented Aug 12, 2019

confirmed it does work. sorry, from the PR description i assumed it was quickinput only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants