Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notification] As a user I want to dismiss the notifications with Esc. #5635

Closed
kittaakos opened this issue Jul 4, 2019 · 2 comments · Fixed by #5830
Closed

[notification] As a user I want to dismiss the notifications with Esc. #5635

kittaakos opened this issue Jul 4, 2019 · 2 comments · Fixed by #5830
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves notifications issues related to notifications

Comments

@kittaakos
Copy link
Contributor

Description

So when I open a running workspace for instance in Gitpod, the following notifications great me:
Screen Shot 2019-07-04 at 09 39 54

The notifications hide the Command Palette so I want to dismiss them ASAP but instead of clicking on Close, Close, and Close, I want to tap-tap-tap (🐈 ) Esc. Esc should dismiss the notification no matter where the focus is. At least as I user I would expect this behavior. Esc would close the top-most item in the notification queue.

Esc must not dismiss a notification which requires an input. I do not know if there is such a notification, though.

Reproduction Steps

OS and Theia version:

Diagnostics:

@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves notifications issues related to notifications labels Jul 4, 2019
@AlexTugarev AlexTugarev self-assigned this Jul 4, 2019
@akosyakov
Copy link
Member

@AlexTugarev are you planning look into it next days? It seems that it can be implemented without aligning with VS Code for now as well? Maybe we better to annotate help wanted?

@AlexTugarev
Copy link
Contributor

I can introduce a notificationFocus context and bind esc for current notifications in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves notifications issues related to notifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants