MonacoOutlineContribution creates broken Range

[colin-grant-work]

Bug Description:

theia/packages/monaco/src/browser/monaco-outline-contribution.ts

Lines 166 to 167 in c7ca0d5

	range: this.asRange(new monaco.Range(0, 0, 0, 0)),
	fullRange: this.asRange(new monaco.Range(0, 0, 0, 0)),

theia/packages/monaco/src/browser/monaco-outline-contribution.ts

Lines 259 to 271 in c7ca0d5

	protected asRange(range: monaco.IRange): Range {
	const { startLineNumber, startColumn, endLineNumber, endColumn } = range;
	return {
	start: {
	line: startLineNumber - 1,
	character: startColumn - 1
	},
	end: {
	line: endLineNumber - 1,
	character: endColumn - 1
	}
	};
	}

Creates a range with all values set to -1

theia/packages/monaco/src/browser/monaco-outline-contribution.ts

Line 245 in c7ca0d5

const parentRange = Range.is(parent) ? parent : this.getFullRange(parent);

Uses vscode-languageserver-types Range.is

Which includes this check:

function uinteger(value) {
    return toString.call(value) === '[object Number]' && 0 <= value && value <= 2147483647;
}

So check fails, leading to a call to

theia/packages/monaco/src/browser/monaco-outline-contribution.ts

Lines 280 to 282 in c7ca0d5

	protected getFullRange(documentSymbol: monaco.languages.DocumentSymbol): Range {
	return this.asRange(documentSymbol.range);
	}

Which passes undefined back into

theia/packages/monaco/src/browser/monaco-outline-contribution.ts

Lines 259 to 271 in c7ca0d5

	protected asRange(range: monaco.IRange): Range {
	const { startLineNumber, startColumn, endLineNumber, endColumn } = range;
	return {
	start: {
	line: startLineNumber - 1,
	character: startColumn - 1
	},
	end: {
	line: endLineNumber - 1,
	character: endColumn - 1
	}
	};
	}

Leading to

Steps to Reproduce:

1. Open a file that has multiple language servers serving it, each able to provide outline data.

This seems to be necessary for the procedure that checks for parents to examine the 'root' nodes.

3. Look in the dev tools.
4. See errors about trying to destructure undefined

Additional Information

• Operating System: RHEL
• Theia Version: 1.34.2