Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Support optional properties iconPath and color in TerminalOptions and ExtensionTerminalOptions #11504

Closed
2 tasks
Tracked by #11520
planger opened this issue Aug 3, 2022 · 3 comments · Fixed by #12060
Closed
2 tasks
Tracked by #11520

[vscode] Support optional properties iconPath and color in TerminalOptions and ExtensionTerminalOptions #11504

planger opened this issue Aug 3, 2022 · 3 comments · Fixed by #12060
Assignees
@rschnekenbu
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented Aug 3, 2022 •
edited
Loading

The type TerminalOptions and ExtensionTerminalOptions miss the optional properties:

  • iconPath: The icon path or ThemeIcon for the terminal
  • color: ThemeColor for the terminal

Related VSCode API issues:
This was referenced Aug 3, 2022
Closed
Closed
Closed
Closed
@paul-marechal paul-marechal added the vscode issues related to VSCode compatibility label Aug 3, 2022
@planger planger changed the title [vscode] Support optional properties iconPath and color in ExtensionTerminalOptions [vscode] Support optional properties iconPath and color in TerminalOptions and ExtensionTerminalOptions Sep 7, 2022
@rschnekenbu
Copy link
Contributor

I will work on this task, please assign it to me.

rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 3, 2023
@rschnekenbu
wip - vscode: Support optional iconPath and color
7675548 
in TerminalOptions and ExtensionTerminalOptions
Contributed on behalf of STMicroelectronics

Fixes eclipse-theia#11504
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 10, 2023
@rschnekenbu
wip - vscode: Support optional iconPath and color
fa5d86e 
in TerminalOptions and ExtensionTerminalOptions
Contributed on behalf of STMicroelectronics

Fixes eclipse-theia#11504
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 10, 2023
@rschnekenbu
wip - vscode: Support optional iconPath and color
65a3d49 
in TerminalOptions and ExtensionTerminalOptions
Contributed on behalf of STMicroelectronics

Fixes eclipse-theia#11504
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 11, 2023
@rschnekenbu
vscode: Support optional iconPath and color
da5f0ce 
in TerminalOptions and ExtensionTerminalOptions
Contributed on behalf of STMicroelectronics

Fixes eclipse-theia#11504
This was referenced Jan 11, 2023
Closed
Merged
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 12, 2023
@rschnekenbu
vscode: Support optional iconPath and color
dc1dfd2 
in TerminalOptions and ExtensionTerminalOptions
Contributed on behalf of STMicroelectronics

Fixes eclipse-theia#11504
JonasHelming pushed a commit that referenced this issue Jan 12, 2023
@rschnekenbu
vscode: Support optional iconPath and color (#12060)
315f2e0 
in TerminalOptions and ExtensionTerminalOptions
Contributed on behalf of STMicroelectronics

Fixes #11504
@JonasHelming
Copy link
Contributor

@rschnekenbu Should we add a new ticket for the stubbed parts and add it to the stub umbrella ticket?

@rschnekenbu rschnekenbu mentioned this issue Jan 16, 2023
Closed
@rschnekenbu
Copy link
Contributor

#12074 will track down the remaining part of the work. I'll ask Philip to edit the umbrella ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
4 participants
@planger @JonasHelming @rschnekenbu @paul-marechal