Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dock panel's currentTitle is not reset to undefined when the last widget is moved elsewhere #10895

Open
lucas-koehler opened this issue Mar 17, 2022 · 0 comments
Labels
shell issues related to the core shell

Comments

@lucas-koehler
Copy link
Contributor

Bug Description:

After the last tab of a TheiaDockPanel in the shell (e.g. main or bottom) was moved to another area (e.g. main to bottom), the currentTitle property is not set to undefined but still points to the moved tab. It seems that the panel's markAsCurrent method is never called to reset to undefined.
This does not happen if the last widget is closed because the currentTitle is properly reset then.

The bug can be observed via the Close Tab in Main Area command. It is still active after the last widget was moved from the main to another area. Executing the command closes the moved widget despite it not being in the main area.

Steps to Reproduce:

  1. Start with empty main area
  2. Open editor
  3. Move editor to bottom area
  4. Execute command Close Tab in Main Area
  5. The editor will be closed in the bottom area

Additional Information

close-main-tab.mp4
  • Operating System: Ubuntu 20.04
  • Theia Version: 1.23.0, commit 4411365
@vince-fugnitto vince-fugnitto added the shell issues related to the core shell label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell issues related to the core shell
Projects
None yet
Development

No branches or pull requests

2 participants